Port browser_privatebrowsing_localStorage_before_after.js to the new per-window PB APIs

RESOLVED FIXED in Firefox 20

Status

()

Firefox
Private Browsing
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Away for a while, Assigned: marioalv)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 20
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
http://mxr.mozilla.org/mozilla-central/source/browser/components/privatebrowsing/test/browser/global/browser_privatebrowsing_localStorage_before_after.js

In order to port this test, the file needs to be copied to the perwindow/ directory, and then instead of setting privateBrowsingEnabled, we need to open a new private browsing window and then run the test on that window.

Note that the per-window version of this test can have both the private and non-private window simultaneously open as opposed to the current way that the test is structured.  Specifically it should avoid setting usePrivateBrowsing directly.
(Reporter)

Updated

5 years ago
Blocks: 801653
Assignee: nobody → marioalv.mozilla
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

5 years ago
Created attachment 683439 [details] [diff] [review]
Patch to migrate the test to the new per window private mode
Attachment #683439 - Flags: review?(ehsan)
(Assignee)

Comment 2

5 years ago
Created attachment 683623 [details] [diff] [review]
Patch to migrate the test to the new per window private mode

Removed an unused function from the patch.
Attachment #683439 - Attachment is obsolete: true
Attachment #683439 - Flags: review?(ehsan)
Attachment #683623 - Flags: review?(ehsan)
(Reporter)

Updated

5 years ago
Attachment #683623 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/bc10a4e38e7a
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
You need to log in before you can comment on or make changes to this bug.