Closed Bug 806699 Opened 7 years ago Closed 7 years ago

Port browser_privatebrowsing_ui.js to the new per-window PB APIs

Categories

(Firefox :: Private Browsing, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 20

People

(Reporter: ehsan, Assigned: marioalv)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

http://mxr.mozilla.org/mozilla-central/source/browser/components/privatebrowsing/test/browser/global/browser_privatebrowsing_ui.js

In order to port this test, the file needs to be copied to the perwindow/ directory, and then instead of setting privateBrowsingEnabled, we need to open a new private browsing window and then run the test on that window.
Assignee: nobody → marioalv.mozilla
Status: NEW → ASSIGNED
I modified the logic of the test, because there were UI elements that don't exist in the new per-window private browsing mode, like pbMenuItem.getAttribute("start") and pbMenuItem.getAttribute("stoplabel").
The test idea is the same: first verify the UI elements when not on per-window private mode, change to private mode (by opening the per-window private mode from the interface) and then verify the UI elements when on per-window private mode.
Attachment #683821 - Flags: review?(ehsan)
Comment on attachment 683821 [details] [diff] [review]
Patch to migrate the test to the new per window private mode

Hmm, this patch doesn't apply cleanly for me:

$ hg qpush -v
applying pach
patching file browser/components/privatebrowsing/test/browser/perwindow/browser_privatebrowsing_ui.js
bad hunk #1 @@ -3,100 +3,82 @@
 (100 99 81 81)
patch failed, rejects left in working dir
errors during apply, please fix and refresh pach

Can you please attach a new version which does?  Thanks!
Attachment #683821 - Flags: review?(ehsan)
I fixed the patch. Let me know if this works OK for you.

Thanks.
Attachment #683821 - Attachment is obsolete: true
Attachment #684168 - Flags: review?(ehsan)
Attachment #684168 - Attachment is patch: true
Comment on attachment 684168 [details] [diff] [review]
Patch to migrate the test to the new per window private mode

Review of attachment 684168 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #684168 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/bfd5f652e5f0
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
You need to log in before you can comment on or make changes to this bug.