Closed
Bug 806731
Opened 12 years ago
Closed 11 years ago
Port test_sts_privatebrowsing.html to the new per-tab PB APIs
Categories
(Firefox :: Private Browsing, defect)
Tracking
()
RESOLVED
FIXED
Firefox 20
People
(Reporter: ehsan.akhgari, Assigned: andreshm)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
15.61 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
http://mxr.mozilla.org/mozilla-central/source/security/manager/ssl/tests/mochitest/stricttransportsecurity/test_sts_privatebrowsing.html In order to port this test, the file needs to be copied to the same directory (perhaps with "_perwindowpb" appended to its file name), and then instead of setting privateBrowsingEnabled, we need to open a new private browsing window and then run the test on that window. Note that the original test should only be added to the list of test files in Makefile.in ifndef MOZ_PER_WINDOW_PRIVATE_BROWSING, and the new test file should be added to the list with the reverse condition.
Comment 1•12 years ago
|
||
Bug 722979 modifies this test.
Reporter | ||
Comment 2•11 years ago
|
||
Removed this test from per-window PB builds: https://hg.mozilla.org/mozilla-central/rev/dcecd5a927bd
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → andres
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #692444 -
Flags: review?(ehsan)
Reporter | ||
Updated•11 years ago
|
Attachment #692444 -
Flags: review?(ehsan) → review+
Reporter | ||
Comment 4•11 years ago
|
||
(BTW, I will be away next week Mon-Wed, so please feel free to ask :jdm for reviews until I'm back. Thanks!)
Reporter | ||
Updated•11 years ago
|
Keywords: checkin-needed
Reporter | ||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e28f0f4b25a4
Keywords: checkin-needed
Reporter | ||
Comment 6•11 years ago
|
||
(In reply to Ehsan Akhgari [:ehsan] from comment #5) > https://hg.mozilla.org/integration/mozilla-inbound/rev/e28f0f4b25a4 Oops, incorrect link. The correct one is: https://hg.mozilla.org/integration/mozilla-inbound/rev/e570d3a26106
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e570d3a26106
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
You need to log in
before you can comment on or make changes to this bug.
Description
•