Closed Bug 806731 Opened 7 years ago Closed 7 years ago

Port test_sts_privatebrowsing.html to the new per-tab PB APIs

Categories

(Firefox :: Private Browsing, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 20

People

(Reporter: ehsan, Assigned: andreshm)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

http://mxr.mozilla.org/mozilla-central/source/security/manager/ssl/tests/mochitest/stricttransportsecurity/test_sts_privatebrowsing.html

In order to port this test, the file needs to be copied to the same directory (perhaps with "_perwindowpb" appended to its file name), and then instead of setting privateBrowsingEnabled, we need to open a new private browsing window and then run the test on that window.  Note that the original test should only be added to the list of test files in Makefile.in ifndef MOZ_PER_WINDOW_PRIVATE_BROWSING, and the new test file should be added to the list with the reverse condition.
Bug 722979 modifies this test.
Depends on: 722979
Removed this test from per-window PB builds: https://hg.mozilla.org/mozilla-central/rev/dcecd5a927bd
Assignee: nobody → andres
Status: NEW → ASSIGNED
Attached patch Patch v1Splinter Review
Attachment #692444 - Flags: review?(ehsan)
Attachment #692444 - Flags: review?(ehsan) → review+
(BTW, I will be away next week Mon-Wed, so please feel free to ask :jdm for reviews until I'm back.  Thanks!)
Keywords: checkin-needed
(In reply to Ehsan Akhgari [:ehsan] from comment #5)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/e28f0f4b25a4

Oops, incorrect link.  The correct one is: https://hg.mozilla.org/integration/mozilla-inbound/rev/e570d3a26106
https://hg.mozilla.org/mozilla-central/rev/e570d3a26106
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
Depends on: 824036
Depends on: 824493
You need to log in before you can comment on or make changes to this bug.