Closed Bug 806739 Opened 7 years ago Closed 7 years ago

Port test_setAndFetchFaviconForPage.js to the new per-tab PB APIs

Categories

(Firefox :: Private Browsing, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 20

People

(Reporter: ehsan, Assigned: marioalv)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/tests/favicons/test_setAndFetchFaviconForPage.js

In order to port this test, the file needs to be copied to the same directory (perhaps with "_perwindowpb" appended to its file name), and then instead of setting privateBrowsingEnabled, we need to open a new private browsing window and then run the test on that window.  Note that the original test should only be added to the list of test files in Makefile.in ifndef MOZ_PER_WINDOW_PRIVATE_BROWSING, and the new test file should be added to the list with the reverse condition.
Assignee: nobody → marioalv.mozilla
Status: NEW → ASSIGNED
Removed this test from per-window PB builds: https://hg.mozilla.org/mozilla-central/rev/743640477bfb
Some remarks:
- I copied the test to the browser folder, because there's where the mochitests reside.
- That implied copying all the functions needed from the tests/head_common.js and tests/favicons/head_favicons to the browser/head.js file.
- Some of those copied functions used old logic, so I simplified the functions a little bit (without changes to the logic of the test).

Please let me know if everything's OK with this test.

Thanks.
Attachment #689109 - Flags: review?(ehsan)
Attachment #689109 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/cb7d59aaa62e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
You need to log in before you can comment on or make changes to this bug.