806747 - [socorro-crashstats] /query needs to check expiration date (test_that_product_versions_are_ordered_correctly is failing)

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Robert Helmer [:rhelmer]]

Splitting off a quick fix for this from bug 803676

Comment 1

[Robert Helmer [:rhelmer]]

r? https://github.com/mozilla/socorro-crashstats/pull/247

This is the little baby version of bug 803676 - much easier to see the actual fixes here.

In that other bug, I am planning to remove currentversions and use /products service throughout the site - it touches a bunch of places though, it'll take some detangling and I don't want to block stage necessarily.

Comment 2

[Robert Helmer [:rhelmer]]

The selenium test "test_that_product_versions_are_ordered_correctly" passes for me locally with this change, and visually browsing around the site I see that the version pulldown is much shorter (it should only list non-expired releases now)

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/dd1a3526fcb9b1c09c32b6414ecf2800b4d94ca1
fixes bug 806747 - currentversions and products calls provide expiration date, views should use them

https://github.com/mozilla/socorro-crashstats/commit/24ae07cc45d988f5fee9cca61795720785bd62bd
Merge pull request #247 from rhelmer/bug806747-check-expiration-date

bug 806747 - currentversions and products calls provide expiration date,...

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED:

http://qa-selenium-stage.mv.mozilla.com:8080/job/socorro.dev.redesign/344/HTML_Report/?

Passed 	tests.test_layout.TestLayout 	test_that_product_versions_are_ordered_correctly 	3.0