Closed
Bug 806748
Opened 12 years ago
Closed 12 years ago
Intermittent browser_dbg_location-changes-blank.js | The source editor not have any text displayed. - Got 546, expected 0
Categories
(DevTools :: Debugger, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 19
People
(Reporter: philor, Assigned: vporof)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
|
6.91 KB,
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
https://tbpl.mozilla.org/php/getParsedLog.php?id=16570725&tree=Fx-Team Rev3 WINNT 5.1 fx-team opt test mochitest-browser-chrome on 2012-10-29 18:47:15 PDT for push aab5d5178047 slave: talos-r3-xp-011 DBG-FRONTEND: Setting the DebuggerView editor source: http://example.com/browser/browser/devtools/debugger/test/browser_dbg_stack.html, loaded: true, options: ({}) DBG-FRONTEND: Setting the DebuggerView editor mode: http://example.com/browser/browser/devtools/debugger/test/browser_dbg_stack.html, content type: undefined TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_location-changes-blank.js | There should be no selected script. TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_location-changes-blank.js | The source editor not have any text displayed. - Got 546, expected 0 Stack trace: JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 471 JS frame :: chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_location-changes-blank.js :: _onEvent :: line 68 native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
|
Assignee | |
Comment 1•12 years ago
|
||
This happens when tabNavigated fires before the fronted had a chance to finish loading a source's text, even though the stackframes were added. While technically correct, the two checks
>> isnot(gDebugger.DebuggerView.Sources.selectedValue, null,
>> "There should be a selected script.");
>> isnot(gDebugger.editor.getText().length, 0,
>> "The source editor should have some text displayed.");
..did, indeed, work for when a source is selected and it's text is shown, but also worked when the text was not yet available and "Loading..." was displayed in the editor. In effect, they triggered a tab navigation, and sometime after that the source finished loading. I added a new assertion in there and made sure that the first source is loaded and shown before the tab navigates.
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
|
||
Updated•12 years ago
|
Attachment #676506 -
Flags: review?(rcampbell) → review+
|
|
Assignee | |
Updated•12 years ago
|
Priority: -- → P2
|
|
Assignee | |
Comment 5•12 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/874b5b0f8a14
Whiteboard: [orange] → [orange][fixed-in-fx-team]
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
|
||
Comment 8•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/874b5b0f8a14
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [orange][fixed-in-fx-team] → [orange]
Target Milestone: --- → Firefox 19
|
||
Updated•12 years ago
|
Keywords: intermittent-failure
|
|
||
Updated•12 years ago
|
Whiteboard: [orange]
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•