806748 - Intermittent browser_dbg_location-changes-blank.js | The source editor not have any text displayed. - Got 546, expected 0

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=16570725&tree=Fx-Team
Rev3 WINNT 5.1 fx-team opt test mochitest-browser-chrome on 2012-10-29 18:47:15 PDT for push aab5d5178047
slave: talos-r3-xp-011

DBG-FRONTEND: Setting the DebuggerView editor source: http://example.com/browser/browser/devtools/debugger/test/browser_dbg_stack.html, loaded: true, options: ({})
DBG-FRONTEND: Setting the DebuggerView editor mode: http://example.com/browser/browser/devtools/debugger/test/browser_dbg_stack.html, content type: undefined
TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_location-changes-blank.js | There should be no selected script.
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_location-changes-blank.js | The source editor not have any text displayed. - Got 546, expected 0
Stack trace:
    JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 471
    JS frame :: chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_location-changes-blank.js :: _onEvent :: line 68
    native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

This happens when tabNavigated fires before the fronted had a chance to finish loading a source's text, even though the stackframes were added. While technically correct, the two checks

>>  isnot(gDebugger.DebuggerView.Sources.selectedValue, null,
>>    "There should be a selected script.");
>>  isnot(gDebugger.editor.getText().length, 0,
>>    "The source editor should have some text displayed.");

..did, indeed, work for when a source is selected and it's text is shown, but also worked when the text was not yet available and "Loading..." was displayed in the editor. In effect, they triggered a tab navigation, and sometime after that the source finished loading. I added a new assertion in there and made sure that the first source is loaded and shown before the tab navigates.

Comment 2

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=16602353&tree=Mozilla-Inbound
Rev3 WINNT 6.1 mozilla-inbound opt test mochitest-browser-chrome on 2012-10-30 16:16:06
slave: talos-r3-w7-067

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_location-changes-blank.js | The source editor not have any text displayed. - Got 546, expected 0

Comment 3

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=16609228&tree=Firefox
Rev3 WINNT 5.1 mozilla-central pgo test mochitest-browser-chrome on 2012-10-30 21:04:34
slave: talos-r3-xp-019

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_location-changes-blank.js | The source editor not have any text displayed. - Got 546, expected 0

Comment 4

[Legacy TBPL/Treeherder Robot]

past
https://tbpl.mozilla.org/php/getParsedLog.php?id=16619619&tree=Fx-Team
Rev3 WINNT 5.1 fx-team opt test mochitest-browser-chrome on 2012-10-31 07:19:05
slave: talos-r3-xp-005

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_location-changes-blank.js | The source editor not have any text displayed. - Got 546, expected 0

Comment 5

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/874b5b0f8a14

Comment 6

[Legacy TBPL/Treeherder Robot]

edmorley
https://tbpl.mozilla.org/php/getParsedLog.php?id=16690247&tree=Mozilla-Inbound
Rev3 WINNT 5.1 mozilla-inbound opt test mochitest-browser-chrome on 2012-11-02 06:57:06
slave: talos-r3-xp-022

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_location-changes-blank.js | The source editor not have any text displayed. - Got 546, expected 0

Comment 7

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=16690247&tree=Mozilla-Inbound
Rev3 WINNT 5.1 mozilla-inbound opt test mochitest-browser-chrome on 2012-11-02 06:57:06
slave: talos-r3-xp-022

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_location-changes-blank.js | The source editor not have any text displayed. - Got 546, expected 0

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/874b5b0f8a14