Closed Bug 806748 Opened 8 years ago Closed 8 years ago

Intermittent browser_dbg_location-changes-blank.js | The source editor not have any text displayed. - Got 546, expected 0

Categories

(DevTools :: Debugger, defect, P2)

18 Branch
x86
Windows XP
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 19

People

(Reporter: philor, Assigned: vporof)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

https://tbpl.mozilla.org/php/getParsedLog.php?id=16570725&tree=Fx-Team
Rev3 WINNT 5.1 fx-team opt test mochitest-browser-chrome on 2012-10-29 18:47:15 PDT for push aab5d5178047
slave: talos-r3-xp-011

DBG-FRONTEND: Setting the DebuggerView editor source: http://example.com/browser/browser/devtools/debugger/test/browser_dbg_stack.html, loaded: true, options: ({})
DBG-FRONTEND: Setting the DebuggerView editor mode: http://example.com/browser/browser/devtools/debugger/test/browser_dbg_stack.html, content type: undefined
TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_location-changes-blank.js | There should be no selected script.
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_location-changes-blank.js | The source editor not have any text displayed. - Got 546, expected 0
Stack trace:
    JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 471
    JS frame :: chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_location-changes-blank.js :: _onEvent :: line 68
    native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
Attached patch v1Splinter Review
This happens when tabNavigated fires before the fronted had a chance to finish loading a source's text, even though the stackframes were added. While technically correct, the two checks

>>  isnot(gDebugger.DebuggerView.Sources.selectedValue, null,
>>    "There should be a selected script.");
>>  isnot(gDebugger.editor.getText().length, 0,
>>    "The source editor should have some text displayed.");

..did, indeed, work for when a source is selected and it's text is shown, but also worked when the text was not yet available and "Loading..." was displayed in the editor. In effect, they triggered a tab navigation, and sometime after that the source finished loading. I added a new assertion in there and made sure that the first source is loaded and shown before the tab navigates.
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #676506 - Flags: review?(rcampbell)
Attachment #676506 - Flags: review?(rcampbell) → review+
Priority: -- → P2
https://hg.mozilla.org/mozilla-central/rev/874b5b0f8a14
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [orange][fixed-in-fx-team] → [orange]
Target Milestone: --- → Firefox 19
Whiteboard: [orange]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.