If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Wifi hotspot: Don't allow user to modify Wifi hotspot settings when Wifi hotspot is enabled

RESOLVED FIXED in B2G C2 (20nov-10dec)

Status

Firefox OS
Gaia::Settings
P1
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: vchang, Assigned: kgrandon)

Tracking

({feature})

unspecified
B2G C2 (20nov-10dec)
ARM
Gonk (Firefox OS)
feature

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: unagi,b2g-testdriver)

Attachments

(1 attachment, 1 obsolete attachment)

We should not allow users to modify Wifi hotspot setttings when Wifi hotspot is enabled.
Flags: needinfo?(lco)

Updated

5 years ago
Whiteboard: unagi,b2g-testdriver

Comment 1

5 years ago
That's fine with me. Let's disable the button that says "Hotspot Settings" in this case.
Flags: needinfo?(lco)

Comment 2

5 years ago
vchang, why not?

On my Galaxy Nexus I have always been always been able to change the SSID if I needed to.
What is the reasoning to prevent it?
(Reporter)

Comment 3

5 years ago
(In reply to Armen Zambrano G. [:armenzg] from comment #2)
> vchang, why not?
> 
> On my Galaxy Nexus I have always been always been able to change the SSID if
> I needed to.
> What is the reasoning to prevent it?

I checked with Galaxy s2, it allows user to modify ssid/security even if Wifi hotspot is enabled. But I found that it still needs to stop Wifi hotspot first, and starts it automatically. 

The limitation is that we need to remove previous configuration in network subsystem before applying the new settings.

Updated

5 years ago
Component: Gaia → Gaia::Settings
Duplicate of this bug: 817029
Blocks: 802677
blocking-basecamp: --- → +

Comment 5

5 years ago
Kevin - can you help resolve this in the next week? This was called out as being of major concern for a partner.
Assignee: nobody → kgrandon
Keywords: feature
Priority: -- → P1
Target Milestone: --- → B2G C2 (20nov-10dec)
(Assignee)

Comment 6

5 years ago
This is addressed by: https://github.com/mozilla-b2g/gaia/pull/6769

For now I went with the option of hiding the "Hotspot settings" button when the hotspot is enabled.

I'm also open to investigating the possibility of live updates so users can update hotspot settings and it will restart properly. I might recommend creating an enhancement ticket for UX to look at.
(Assignee)

Comment 7

5 years ago
Created attachment 687463 [details] [diff] [review]
Github pull request pointer
Attachment #687463 - Flags: review?(ehung)
(Assignee)

Comment 8

5 years ago
I guess I made the "patch" wrong. It doesn't redirect, do I upload an HTML document?

Pull request here: https://github.com/mozilla-b2g/gaia/pull/6769
(Assignee)

Updated

5 years ago
Attachment #687463 - Attachment is patch: true
(Assignee)

Comment 9

5 years ago
Created attachment 687464 [details]
Github pull request pointer
Attachment #687463 - Attachment is obsolete: true
Attachment #687463 - Flags: review?(ehung)
Attachment #687464 - Flags: review?(ehung)
Comment on attachment 687464 [details]
Github pull request pointer

r=me, thanks for your hard work!
Attachment #687464 - Flags: review?(ehung) → review+
(Assignee)

Comment 11

5 years ago
Marking as fixed.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
blocking-basecamp: + → ---
You need to log in before you can comment on or make changes to this bug.