806761 - Airplane mode: Should also turn off Wifi hotspot when we are in airplane mode.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect, P3)

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/airplane_mode.js#L69

We do turn off wifi here.

Comment 2

[Vincent Chang[:vchang][changyihsin]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #1)
> https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/airplane_mode.
> js#L69
> 
> We do turn off wifi here.

Also need to disable Wifi hotspot I think. 
Set "tethering.wifi.enabled = false".

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Vincent Chang from comment #2)
> (In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #1)
> > https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/airplane_mode.
> > js#L69
> > 
> > We do turn off wifi here.
> 
> Also need to disable Wifi hotspot I think. 
> Set "tethering.wifi.enabled = false".

My mistake. Rex, can you take it?

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: Fix to bug 806761

Patch attached.  Would you help reviewing the code, Tim?

Note that I don't restore Wifi tethering settings when leaving airplane mode, because Wifi tethering can't be switched on before data connection is established.
(Tethering would be set to off immediately if I turned it on)

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Making sure this is a bb+ bug first.

This should be a bb+ block coz not fixing this bug means shipping an incomplete airplane mode. We don't want to crash airplanes.

Comment 6

[Mike Connor [:mconnor]]

blocking+, something we must fix by ship.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 676941 [details]
Fix to bug 806761

r=me

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://github.com/mozilla-b2g/gaia/pull/6107

Comment 9

[Angela Hubenya]

Defect is verified as fixed using Unagi, build 20121231070201

Comment 10

[Swarnava Sengupta (:Swarnava)]

i can reproduce this bug with geeksphone keon stable build v1.1.0.0 buildid: 20130724051151

Comment 11

[KM Lee [:rexboy] (inactivate after Sep. 22)]

I can't reproduce it.

My step is
1. Open settings
2. internet sharing -> Turn on wi-fi hotspot
3. turn on airplane mode

and the wi-fi hotspot is turned off as expected.
Can someone confirm it ?

Gaia commit: v1-train, c97b3e11acad10a757b00fdffb5caab54afb6fea in Jul. 26

Comment 12

[Swarnava Sengupta (:Swarnava)]

and what about bluetooth? is it working on airplane mode or not?

Comment 13

[Swarnava Sengupta (:Swarnava)]

Attachment: screenshot_GPkeon

here is the screenshot

Comment 14

[Deian Stefan]

Having same issue. Turning on airplane mode after enabling tethering
does not shut down the actual AP, though the icons for "internet
sharing" indicate off. Moreover, when turning airplane mode off the AP
still runs, but the icons do not reappear/switch to on/blue (clicking
on the enable wifi hotspot turns the hotspot off).

Comment 15

[Evelyn Hung]

(In reply to Deian Stefan from comment #14)
> Having same issue. Turning on airplane mode after enabling tethering
> does not shut down the actual AP, though the icons for "internet
> sharing" indicate off. 
Seems a device interface issue. 
Vincent, can you check this? Thanks.

Comment 16

[Vincent Chang[:vchang][changyihsin]]

I don't find this problem in b2g18 + gaia v1-train using buri. Not sure if this is still a problem.

Comment 17

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Closing since it's been a while and we still can't reproduce it.

Please reopen if it still doesn't work.