806762 - Thunderbird build is broken after Bug 792180 (error: ‘NS_UNLIKELY’ was not declared in this scope)

Status: RESOLVED FIXED

(MailNews Core :: Networking: POP, defect)

Description

[ojab]

Attachment: patch

c++ -o nsPop3IncomingServer.o -c -I../../../mozilla/dist/stl_wrappers -I../../../mozilla/dist/system_wrappers -include /sources/comm-central/mozilla/config/gcc_hidden.h -DMOZ_GLUE_IN_PROGRAM -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES  -DMOZ_THUNDERBIRD=1 -DOSTYPE=\"Linux3.6\" -DOSARCH=Linux -DHAVE_MOVEMAIL  -I/sources/comm-central/mailnews/local/src -I. -I../../../mozilla/dist/include -I../../../mozilla/dist/include/nsprpub  -I/usr/include/nspr -I/usr/include/nss      -fPIC  -pedantic -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Wtype-limits -Wempty-body -Werror=conversion-null -Wno-ctor-dtor-privacy -Wno-overlength-strings -Wno-invalid-offsetof -Wno-variadic-macros -Wcast-align -Wno-long-long -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -std=gnu++0x -pthread -pipe  -DNDEBUG -DTRIMMED -g -Os -freorder-blocks  -fomit-frame-pointer   -DMOZILLA_CLIENT -include ../../../comm-config.h -MD -MF .deps/nsPop3IncomingServer.pp /sources/comm-central/mailnews/local/src/nsPop3IncomingServer.cpp
/sources/comm-central/mailnews/local/src/nsPop3IncomingServer.cpp: In member function ‘virtual nsresult nsPop3IncomingServer::AddUidlToMark(const char*, int32_t)’:
/sources/comm-central/mailnews/local/src/nsPop3IncomingServer.cpp:626:35: error: ‘NS_UNLIKELY’ was not declared in this scope
/sources/comm-central/mailnews/local/src/nsPop3IncomingServer.cpp: In member function ‘virtual nsrefcnt nsPop3GetMailChainer::Release()’:
/sources/comm-central/mailnews/local/src/nsPop3IncomingServer.cpp:666:1: warning: deleting object of polymorphic class type ‘nsPop3GetMailChainer’ which has non-virtual destructor might cause undefined behaviour [-Wdelete-non-virtual-dtor]
make[8]: *** [nsPop3IncomingServer.o] Error 1

Comment 1

[Mark Banner (:standard8)]

Comment on attachment 676498 [details] [diff] [review]
patch

Thanks for catching this ahead of time, looks like we can land it at any time.

Comment 2

[Mark Banner (:standard8)]

https://hg.mozilla.org/comm-central/rev/d2fc0b13fff4

Thanks for doing the patch.