Closed Bug 806930 Opened 13 years ago Closed 12 years ago

Links to marketplace on each app on the /apps page don't work

Categories

(www.mozilla.org :: Pages & Content, defect)

Product:
www.mozilla.org
Component:
Pages & Content
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: rik, Assigned: dhorner)

References

(
URL
)

Details

On this page, if I click on Solitaire (either the image or the name of the app), it won't go to the marketplace.
In a desktop browser? Apparently it's not supposed to - we're disabling these links for everyone but Firefox Aurora on Android as per the spec.
Yes, on Mac. Who whould we discussed this behaviour with? It feels really weird. If we don't let links be links, we should disable them entirely. Right now, I'm seeing the hand cursor and the destination link on the bottom so it feels broken rather than on purpose.
(In reply to Anthony Ricaud (:rik) from comment #2) > Yes, on Mac. Who whould we discussed this behaviour with? It feels really > weird. > If we don't let links be links, we should disable them entirely. Right now, > I'm seeing the hand cursor and the destination link on the bottom so it > feels broken rather than on purpose. Good point. Maybe we should use spans (though they at least need a tabindex to be focus-able to expose the :hover/:focus qr-codes for keyboard-only users).
IMHO, we should just let them go to the marketplace. The marketplace has messages to explain what's happening there. They even have a link to explain how to override this.
Assigning to Dan to decide on behaviour.
Assignee: nobody → dhorner
Flags: needinfo?(dhorner)
We should just remove the preventDefault. Otherwise, we'll continue losing traffic to the Marketplace (which is kind of the point of this page).
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/d81e5360757b99317c1aba3beb4671765f54ade6 do not preventDefault on links to Marketplace apps (bug 806930) https://github.com/mozilla/bedrock/commit/3078e341fe0ab2cb25831e468ffe05558ce26d90 Merge pull request #649 from cvan/preventDefault do not preventDefault on links to Marketplace apps (bug 806930)
Looks like this has been deployed?
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: needinfo?(dhorner)
Resolution: --- → FIXED
This is fixed links now go to the marketplace. There are a few layout bugs on mobile but this issue is fixed
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.