Closed Bug 806977 Opened 7 years ago Closed 3 years ago

Zip build installs can lead to duplicate taskbar icons

Categories

(Toolkit :: NSIS Installer, defect)

15 Branch
x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: bbondy, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #768378 +++

Bug 768378 fixed one problem which led to having duplicate icons, but there seems to be at least one more problem with the same effect left.

In particular I looked into Mak's lnk and registry entries:

We get double taskbar icons when the registry AppUserModelID != AppUserModelID of the shortcut.

Mak's Nightly.lnk has the following:
- Points to the Mozilla Firefox installation dir: C:\\Program Files (x86)\\Mozilla Firefox
- AppUserModelID: EEFEA8717BC47F65

Your registry has the following for the path C:\\Program Files (x86)\\Mozilla Firefox:
- AppUserModelID: E7CF176E110C211B


So the problem is that Mak's lnk should have been updated to E7CF176E110C211B
But instead it's using the appusermodel id of "C:\\Program Files (x86)\\Nightly"="EEFEA8717BC47F65".
I did notice that this installation also has a target which includes  "-P default", so that may be a possible reason why the appusermodelid doesn't get updated. We go through the lnk files and if a target path matches the path we're updating, we update the appusermodelid.  Perhaps that call is returning the command line args with the path:
http://dxr.mozilla.org/mozilla-central/toolkit/mozapps/installer/windows/nsis/common.nsh.html#l6846
Attached file Mak's registry + lnk
Assignee: nobody → netzen
yes, my setup is not exactly "standard", but doesn't have many differences:
- I install into Mozilla Firefox folder, not Nightly
- I modify the shortcut to use the default profile, cause in any other cases I want to be prompted which profile to use
oh and I usually install by unzipping latest-trunk to the folder (don't use the installer), then I pin the icon. Though the last time I did this was months ago.
Comment 4 is the reason, thanks for mentioning it. I verified the command line params after the shortcut and that's not the problem.

Basically the shortcut gets fixed in the PostUpdate operation.

We don't run PostUpdate operations from zip installs.  This has caused problems before too with the maintenance service not being used.  We ended up wontfix'ing that bug though.

http://dxr.mozilla.org/mozilla-central/toolkit/mozapps/installer/windows/nsis/common.nsh.html#l5118

We only run PostUpdate when uninstall.log exists and that doesn't exist for zip build installs.
Summary: Some installations still have double taskbar icons. → Zip build installs can lead to duplicate taskbar icons
Since today, this bug returned on the Aurora branch.

- I installed Aurora to a custom folder
- I don't use the -P parameter, my Aurora profile is my default one

bbondy, feel free to use me as another test subject.
Summary: Zip build installs can lead to duplicate taskbar icons → Some installations still have double taskbar icons.
TheOne, I think your problem is fixed in Bug 768378, but that has only landed on Nightly.  Nothing has changed on Aurora so likely you just reproduced it by chance.
(In reply to Brian R. Bondy [:bbondy] from comment #5)
> Basically the shortcut gets fixed in the PostUpdate operation.
> 
> We don't run PostUpdate operations from zip installs.

Why did this happen just now and not in the last months? Just due to some recent changes that enforced a new appusermodelid?

I just verified I don't have an uninstall.log
If this kind of install is sort of unsupported, I have no problems if this ends up wontfixed.
It is unsupported, but we may want to fix anyway. Not sure. 
The similar bug for zip builds can be found here: Bug 780961.

> Why did this happen just now and not in the last months? Just due to 
> some recent changes that enforced a new appusermodelid?

Ya, basically to fix a different problem with having a bad appusermodelid with leading spaces, we always write the correct appusermodel id to the registry now.

But your lnk files aren't getting updated because of the missing uninstall.log and because PostUpdate doesn't run.
Flags: needinfo?
I'm going to wait for rstrong's feedback once he gets back. 

It is unsupported, but problems keep creeping up because we don't run /PostUpdate, and that wastes dev time. So I think I'd rather just fix this now and avoid future investigations for the same problem.
Flags: needinfo?
See Also: → 806977
Summary: Some installations still have double taskbar icons. → Zip build installs can lead to duplicate taskbar icons
Assignee: netzen → nobody
I tried to re-install Firefox and follow some of the other people's suggestion to no avail. Eventually I found I have to click START -> All Apps then scroll down to Mozilla Firefox. Right click on it and make sure Pin to Start and Pin to Taskbar are present or else you have to unpin both of them. Then right click and choose pin to Taskbar. That works for me and hopefully others. Now I have only one instance and whenever I ran Firefox I have a bar underneath the icon meaning it is active.
Closing for staleness. Please file a new bug if you have a similar issue.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.