[AccessFu] incremental build improvement

RESOLVED FIXED in mozilla19

Status

()

Core
Disability Access APIs
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: davidb, Assigned: davidb)

Tracking

unspecified
mozilla19
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 676625 [details] [diff] [review]
fix

I described some issues I was seeing with changes to accessfu not migrating for incremental builds. It might only happen on mac.

I'll attach the fix Ted suggested.
Attachment #676625 - Flags: review?(ted)
Attachment #676625 - Flags: feedback?(eitan)
Comment on attachment 676625 [details] [diff] [review]
fix

I don't have much to give feedback here for. The build system is a mystery to me. But if this solves issues, I'm all for it.
Attachment #676625 - Flags: feedback?(eitan) → feedback+
Comment on attachment 676625 [details] [diff] [review]
fix

Review of attachment 676625 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/jsat/Makefile.in
@@ +10,5 @@
>  include $(DEPTH)/config/autoconf.mk
>  
> +INSTALL_TARGETS += ACCESSFU
> +
> +ACCESSFU_FILES = \

nit: you could use := here
Attachment #676625 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/dc436cae60fc
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.