[BB][Clock] Apply building blocks [headers]

VERIFIED FIXED

Status

VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: basiclines, Assigned: basiclines)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Applied headers.css from shared/style folder.
There is a huge drawback in the Clock app: is it using 6px as base font-size for their rem units, so any BB applied will be seen smaller as 10px is the base unit for all the building blocks and Gaia apps.

I encourage to change all the sizes ASAP for being synced with Gaia base font size.
The change is easy but takes time to do, you only need a basic math operation.
(Assignee)

Comment 2

6 years ago
Created attachment 676661 [details]
PR

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):
Attachment #676661 - Flags: review?(iliu)
Attachment #676661 - Flags: approval-gaia-master?(francisco.jordano)
Comment on attachment 676661 [details]
PR

a=me

No js changes, dom not adding inline js, as long as Iliu gives the r+ please merge.

Thanks,
Francisco.
Attachment #676661 - Flags: approval-gaia-master?(francisco.jordano) → approval-gaia-master+
Comment on attachment 676661 [details]
PR



1. The central point of analog clock face is missed. (A little too high, you could check the SVG clock or the background image with wrong style or size)

2. If you press on the clock face and move it to left, you could see the edit alarm page. (overflow-y: scroll; --> change to overflow: hidden)

3. The time picker unit size is a little incorrect. If you scroll the picker to the end, you could see the wrong offset and not align to the center. (picker unit size with decimal point. Check and refine it without decimal point)

4. Alarm goes off page can be scrolled to the top. (Something wrong for the overflow hidden)
(In reply to Ian Liu [:ianliu] from comment #4)
> Comment on attachment 676661 [details]
> PR
> 1. The central point of analog clock face is missed. (A little too high, you
> could check the SVG clock or the background image with wrong style or size)
> 
> 2. If you press on the clock face and move it to left, you could see the
> edit alarm page. (overflow-y: scroll; --> change to overflow: hidden)
> 
> 3. The time picker unit size is a little incorrect. If you scroll the picker
> to the end, you could see the wrong offset and not align to the center.
> (picker unit size with decimal point. Check and refine it without decimal
> point)
> 
> 4. Alarm goes off page can be scrolled to the top. (Something wrong for the
> overflow hidden)

It looks good to me.
And fixed all the comments according my feedback.
Thanks for @basiclines 's help to sync BB for Clock APP.
Great job! 

r=me
Attachment #676661 - Flags: review?(iliu) → review+
The pr was merged.
https://github.com/mozilla-b2g/gaia/pull/6091

We can close the issue.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 7

6 years ago
This issue is fixed for  device Ungia; build #20130112070202v.1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.