Closed
Bug 807061
Opened 12 years ago
Closed 12 years ago
start-msvc10 is not picking up Windows 8 SDK
Categories
(Firefox Build System :: MozillaBuild, task)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bbondy, Assigned: jimm)
References
Details
Attachments
(1 file, 1 obsolete file)
3.47 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
I have 7.0A and 8.0 SDK, but when I start start-msvc10.bat the following happens: ... Windows SDK Version: 8.0 Using VC 2010 built-in SDK ... But the INCLUDE path which is set by the call to vcvarsall.bat includes the path to the Win7 SDK. ECHO $INCLUDE c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\INCLUDE;c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\ATLMFC\INCLUDE;c:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\include;
Comment 1•12 years ago
|
||
I think you're supposed to use the SDK Chooser tool to set the SDK for your compiler nowadays.
Comment 2•12 years ago
|
||
"Windows SDK Configuration Tool", in the start menu folder for the SDK.
Reporter | ||
Comment 3•12 years ago
|
||
Ah, OK thanks. Works.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WORKSFORME
Reporter | ||
Comment 4•12 years ago
|
||
C:\Program Files\Microsoft SDKs\Windows\v7.1\Setup\WindowsSdkVer.exe
Reporter | ||
Comment 5•12 years ago
|
||
Also they list v8.0 and v8.0A not sure if we should add a different bug for v8.0A?
Reporter | ||
Comment 6•12 years ago
|
||
Is there no way to default to 8.0SDK? Or is it just my computer? Just wondering if people will run into this when we make metro builds on by default.
Assignee | ||
Comment 7•12 years ago
|
||
(In reply to Brian R. Bondy [:bbondy] from comment #4) > C:\Program Files\Microsoft SDKs\Windows\v7.1\Setup\WindowsSdkVer.exe I can't find this in the 8.0 sdk. I think our scripts should set up the env without this.
Reporter | ||
Comment 8•12 years ago
|
||
Reopening for now. I'm not sure what the proper way is with the win8 SDK but I don't have that exe for the Win8 SDK either. We could add code to manually set the INCLUDE / other environment variables maybe.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Assignee | ||
Comment 9•12 years ago
|
||
Looks like guess-msvc already supports the 8.0 kit - F:\Mozilla\firefox\build>guess-msvc.bat Visual C++ 9 directory: C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\ Visual C++ 10 directory: F:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\ Visual C++ 11 directory: C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\ Windows SDK directory: C:\Program Files (x86)\Windows Kits\8.0\ Windows SDK version: 8.0
Comment 10•12 years ago
|
||
Good ole' Microsoft, changing the way things work with every single SDK release.
Assignee | ||
Comment 11•12 years ago
|
||
Need to do some build testing, and update the x64 script as well.
Assignee: nobody → jmathies
Assignee | ||
Comment 12•12 years ago
|
||
This builds fine for 32-bit. I'll fire off a 64-bit build tonight to be sure. The vc11 scripts should work fine with the built in sdk that comes with vc 2011.
Attachment #677032 -
Attachment is obsolete: true
Attachment #677138 -
Flags: review?(ted)
Updated•12 years ago
|
Attachment #677138 -
Flags: review?(ted) → review+
Assignee | ||
Comment 13•12 years ago
|
||
https://hg.mozilla.org/mozilla-build/rev/59156d4d5ab2
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Updated•1 year ago
|
Product: mozilla.org → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•