Closed
Bug 807160
Opened 13 years ago
Closed 13 years ago
Youtube titles arent shown in Video app
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(blocking-basecamp:-)
VERIFIED
FIXED
| blocking-basecamp | - |
People
(Reporter: daleharvey, Assigned: daleharvey)
Details
(Keywords: polish)
Attachments
(1 file)
|
360 bytes,
text/html
|
fabrice
:
review+
vingtetun
:
approval-gaia-v1+
|
Details |
When playing videos from youtube, the title should be shown
possible regression due to changes in youtube api
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → dale
blocking-basecamp: --- → ?
|
|
Assignee | |
Comment 1•13 years ago
|
||
This hasnt been triaged yet, but is a small fix so figured I would r? and merge when it gets triaged
Attachment #676865 -
Flags: review?(fabrice)
|
||
Updated•13 years ago
|
Component: General → Gaia
|
|
||
Updated•13 years ago
|
Attachment #676865 -
Flags: review?(fabrice) → review+
|
||
Comment 2•13 years ago
|
||
Not blocking, per triage, but we'd take a low risk patch.
blocking-basecamp: ? → -
Keywords: polish
|
|
Assignee | |
Comment 3•13 years ago
|
||
Comment on attachment 676865 [details]
Show youtube title in Video app
NOTE: If blocking-basecamp+ is set, just land it for now.
[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bad testing
User impact if declined: Youtube videos without titles
Testing completed: yes?
Risk to taking this patch (and alternatives if risky): Very low risk patch
Attachment #676865 -
Flags: approval-gaia-master?(21)
|
|
Assignee | |
Comment 4•13 years ago
|
||
I updated the pull request based on feedback
I took out the fix for youtube titles that have + replacing spaces as that should be fixed in platform, filed a new bug @ https://bugzilla.mozilla.org/show_bug.cgi?id=809188
Attachment #676865 -
Flags: approval-gaia-master?(21) → approval-gaia-master+
|
|
Assignee | |
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Unable to test it on "Unagi"
Build ID:20130103070201
YouTube videos not working
Verified on "Unagi"
build ID:20130112070202
Titles are shown on YouTube video.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•