807186 - Parts of the menu are obscured when keyboard is focused

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: screenshot

1. Go to https://etherpad.mozilla.org/ on Firefox for Android 2012-10-30
2. Create a new public pad.
3. Ensure you are focused on the main content area by typing a few words.
4. Tap the top right settings menu.

The Quit button is obscured.

See screenshot.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

This might be a dupe. I thought the menu was supposed to be pannable?

Comment 2

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(fwiw, I tried panning, and it didn't work.)

Comment 3

[Sriram Ramasubramanian [:sriram]]

I might have seen this bug. Basically the list is pannable. But, when keyboard comes up, the list doesn't resize, and still occupies same height and is obscured. But the menu popup shrinks in response to the keyboard. I'll try to find if we can monitor PopupWindow's bounds.

Comment 4

[Sriram Ramasubramanian [:sriram]]

Attachment: Option

Unfortunately we cannot monitor PopupWindow's layout changes. The only option I could come close to was show the PopupWindow with Quit option -- but still obscured. Is this fine?

Comment 5

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

> Unfortunately we cannot monitor PopupWindow's layout changes. The only
> option I could come close to was show the PopupWindow with Quit option --
> but still obscured. Is this fine?

Won't that option still be fully obscured on phones with smaller screens? (e.g. Nexus One)

Comment 6

[Sriram Ramasubramanian [:sriram]]

True! All that would come to is.. "please close the keyboard to access the menu". But at least it would give an impression that there are more menu items, that the background of PopupWindow showing the shadow -- making it feel like there are no more items.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

I'd like to know why PopupWindow is giving us problems. The old version of the menu was pannable. Maybe we should be thinking about refactoring the menu to give us better panning support.

Comment 8

[Sriram Ramasubramanian [:sriram]]

Which version of the menu was pannable?

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Sriram Ramasubramanian [:sriram] from comment #8)
> Which version of the menu was pannable?

The menu in Fx16 seems to be pannable. I notice that "Quit" is still obscured, but I can pan.

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

Instead of monitoring the PopupWindow, can we check it size when we create the menu? At least then, we could size the child view better.

Comment 11

[Sriram Ramasubramanian [:sriram]]

In Fx16 we use a <ScrollView> .. bunch of LinearLayout ... </ScrollView>
In later versions we use a ListView.
The effect is just the same. In face, this ListView will pan if the list entries are a lot like in Fx16. But I'll face the same obscuring problem, where anything after "Clear settings" is not seen in Fx16.

I could try monitoring for onLayout() changes in MenuPanel, and shrink its height if I happen to get any change in values, when IME is shown. I'll update on it soon.

Comment 12

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

I don't see a Quit option in the nightlies anymore. Is this intended? And should the summary of this bug be changed somehow, if it's still applicable?

Comment 14

[Andrei Hajdukewycz [:sancus]]

I'd say it's still an applicable bug, menu items are still being obscured by it, even if Quit is going away.

Comment 16

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.