807212 - Add JS_GetTypedArrayBuffer to jsfriendapi

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

It is inexplicably missing :-)

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Add JS_GetTypedArrayBuffer

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Use TypedArray methods instead of direct slot access

Drive-by cleanup, which may also make these functions a tiny bit more efficient.

Comment 3

[Steve Fink [:sfink] [:s:]]

Comment on attachment 676900 [details] [diff] [review]
Use TypedArray methods instead of direct slot access

Review of attachment 676900 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, efaust cooked up those JS_GetObjectAs* methods for bz and slipped it in when I was on vacation. :-) I like your cleanup, thanks.

Comment 4

[Steve Fink [:sfink] [:s:]]

Comment on attachment 676898 [details] [diff] [review]
Add JS_GetTypedArrayBuffer

Review of attachment 676898 [details] [diff] [review]:
-----------------------------------------------------------------

Please call this JS_GetArrayBufferViewBuffer so it works for DataViews as well, and test it.

Or what I'm really saying: just steal my patch from bug 807223 and review it yourself. I think it's fine to land then without further review.

::: js/src/jstypedarray.cpp
@@ +3707,5 @@
> +    obj = CheckedUnwrap(maybecx, obj);
> +    if (!obj)
> +        return nullptr;
> +    JS_ASSERT(obj->isTypedArray());
> +    return obj->getFixedSlot(TypedArray::BUFFER_SLOT).toInt32();

You probably didn't mean .toInt32().

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/95187d8e170c
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d0cfc4fd49f

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4d0cfc4fd49f