Closed
Bug 807271
Opened 13 years ago
Closed 13 years ago
Removes `api-utils` from base64's example
Categories
(Add-on SDK Graveyard :: Documentation, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: zer0, Assigned: zer0)
Details
Attachments
(1 file)
It seems that after the layout changes `base64` is now a High-Level APIs, as showed in the documentation as well, on the sidebar. Therefore, even if `api-utils/base64` still works for backward compatibility, the examples should be updated.
| Assignee | ||
Comment 1•13 years ago
|
||
Pointer to Github pull-request
| Assignee | ||
Updated•13 years ago
|
Attachment #676971 -
Flags: review?(wbamberg)
| Assignee | ||
Updated•13 years ago
|
Assignee: nobody → zer0
Comment 2•13 years ago
|
||
Comment on attachment 676971 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/640
The doc change looks fine: however, I'm not really qualified to review the code change that's in here... if you can get a reviewer for that, then I'm happy with the docs change.
| Assignee | ||
Updated•13 years ago
|
Attachment #676971 -
Flags: review?(rFobic)
Comment 3•13 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/48aabd280a8c5d26ddad10c084b68874a8e35918
Bug 807271 - Removes `api-utils` from base64's example
- Removed `api-utils` from base64's example
- Fix a nit on `base64` module to avoid module scope's pollution
https://github.com/mozilla/addon-sdk/commit/2cf3686217cc60ff94f94485e40db31b163b8361
Merge pull request #640 from ZER0/base64-doc/807271
Bug 807271 - Removes `api-utils` from base64's example r=@gozala
Updated•13 years ago
|
Attachment #676971 -
Flags: review?(rFobic) → review+
| Assignee | ||
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Attachment #676971 -
Flags: review?(wbamberg) → review+
You need to log in
before you can comment on or make changes to this bug.
Description
•