Over to Eitan. Ehsan did you have accessibility settings turned on on android?
Assignee: dbolter → eitan
Summary: We spend 15ms running AccessFu.jsm on mobile startup → [AccessFu] We spend 15ms running AccessFu.jsm on mobile startup
I grabbed the profile. I didn't opt into anything. How do I check?
OS: Mac OS X → Android
Hardware: x86 → ARM
Update: accessibility setting was not enabled AFAICT
Is there such a thing as an acceptable amount of time?
(In reply to comment #4) > Is there such a thing as an acceptable amount of time? Yes, 0. ;-)
Fair enough :)
Created attachment 677230 [details] [diff] [review] WIP Here is the profile before: http://people.mozilla.com/~bgirard/cleopatra/?report=298ba1521e337073883f9e7857e5ea7119e64b83 Here it is after: http://people.mozilla.com/~bgirard/cleopatra/?report=0a4abc01084588a58c88a4848467df61e03e09ec I'm still new to this tool. But it looks like startup in AccessFu dropped from 27ms to 2ms, not quite 0 :) Need to test this patch further to make sure it does not break stuff.
Couldn't you just replace these with lazy getters?
For Input.keyMap? Yeah I'll do that. Not sure where else you see that it could be used. The real problem was loading additional modules too early.
(In reply to comment #9) > For Input.keyMap? Yeah I'll do that. Not sure where else you see that it could > be used. The real problem was loading additional modules too early. I was talking about the Cu.import's.
Created attachment 678295 [details] [diff] [review] Load AccessFu resources on-demand. Here is a more cleaned up version, ready for review. Makes things much much faster.
Attachment #678295 - Flags: review?(dbolter) → review+
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
You need to log in before you can comment on or make changes to this bug.