[AccessFu] We spend 15ms running AccessFu.jsm on mobile startup

RESOLVED FIXED in Firefox 19

Status

()

Firefox for Android
General
RESOLVED FIXED
5 years ago
2 years ago

People

(Reporter: Ehsan, Assigned: eeejay)

Tracking

(Blocks: 1 bug, {perf})

unspecified
Firefox 19
ARM
Android
Points:
---

Firefox Tracking Flags

(fennec+)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Over to Eitan.

Ehsan did you have accessibility settings turned on on android?
Assignee: dbolter → eitan
Keywords: perf
Summary: We spend 15ms running AccessFu.jsm on mobile startup → [AccessFu] We spend 15ms running AccessFu.jsm on mobile startup

Updated

5 years ago
Blocks: 807322
I grabbed the profile. I didn't opt into anything. How do I check?
OS: Mac OS X → Android
Hardware: x86 → ARM
Update: accessibility setting was not enabled AFAICT

Updated

5 years ago
tracking-fennec: --- → ?
(Assignee)

Comment 4

5 years ago
Is there such a thing as an acceptable amount of time?
(Reporter)

Comment 5

5 years ago
(In reply to comment #4)
> Is there such a thing as an acceptable amount of time?

Yes, 0.  ;-)
(Assignee)

Comment 6

5 years ago
Fair enough :)
(Assignee)

Comment 7

5 years ago
Created attachment 677230 [details] [diff] [review]
WIP

Here is the profile before:
http://people.mozilla.com/~bgirard/cleopatra/?report=298ba1521e337073883f9e7857e5ea7119e64b83

Here it is after:
http://people.mozilla.com/~bgirard/cleopatra/?report=0a4abc01084588a58c88a4848467df61e03e09ec

I'm still new to this tool. But it looks like startup in AccessFu dropped from 27ms to 2ms, not quite 0 :)
Need to test this patch further to make sure it does not break stuff.
(Reporter)

Comment 8

5 years ago
Couldn't you just replace these with lazy getters?
(Assignee)

Comment 9

5 years ago
For Input.keyMap? Yeah I'll do that. Not sure where else you see that it could be used. The real problem was loading additional modules too early.
(Reporter)

Comment 10

5 years ago
(In reply to comment #9)
> For Input.keyMap? Yeah I'll do that. Not sure where else you see that it could
> be used. The real problem was loading additional modules too early.

I was talking about the Cu.import's.
tracking-fennec: ? → +
(Assignee)

Comment 11

5 years ago
Created attachment 678295 [details] [diff] [review]
Load AccessFu resources on-demand.

Here is a more cleaned up version, ready for review. Makes things much much faster.
Attachment #677230 - Attachment is obsolete: true
Attachment #678295 - Flags: review?(dbolter)
Attachment #678295 - Flags: review?(dbolter) → review+
https://hg.mozilla.org/mozilla-central/rev/0dea4f9a9133
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
You need to log in before you can comment on or make changes to this bug.