807315 - [AccessFu] We spend 15ms running AccessFu.jsm on mobile startup

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[(no longer active)]

http://people.mozilla.com/~bgirard/cleopatra/?report=439a965571b0283876e8d75722d7a370b5b49c52

Please, let's not!

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

Over to Eitan.

Ehsan did you have accessibility settings turned on on android?

Comment 2

[Benoit Girard (:BenWa)]

I grabbed the profile. I didn't opt into anything. How do I check?

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

Update: accessibility setting was not enabled AFAICT

Comment 4

[Eitan Isaacson [:eeejay]]

Is there such a thing as an acceptable amount of time?

Comment 5

[(no longer active)]

(In reply to comment #4)
> Is there such a thing as an acceptable amount of time?

Yes, 0.  ;-)

Comment 6

[Eitan Isaacson [:eeejay]]

Fair enough :)

Comment 7

[Eitan Isaacson [:eeejay]]

Attachment: WIP

Here is the profile before:
http://people.mozilla.com/~bgirard/cleopatra/?report=298ba1521e337073883f9e7857e5ea7119e64b83

Here it is after:
http://people.mozilla.com/~bgirard/cleopatra/?report=0a4abc01084588a58c88a4848467df61e03e09ec

I'm still new to this tool. But it looks like startup in AccessFu dropped from 27ms to 2ms, not quite 0 :)
Need to test this patch further to make sure it does not break stuff.

Comment 8

[(no longer active)]

Couldn't you just replace these with lazy getters?

Comment 9

[Eitan Isaacson [:eeejay]]

For Input.keyMap? Yeah I'll do that. Not sure where else you see that it could be used. The real problem was loading additional modules too early.

Comment 10

[(no longer active)]

(In reply to comment #9)
> For Input.keyMap? Yeah I'll do that. Not sure where else you see that it could
> be used. The real problem was loading additional modules too early.

I was talking about the Cu.import's.

Comment 11

[Eitan Isaacson [:eeejay]]

Attachment: Load AccessFu resources on-demand.

Here is a more cleaned up version, ready for review. Makes things much much faster.

Comment 12

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0dea4f9a9133

Comment 13

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0dea4f9a9133