No confirmation message appears while performing reclassification

NEW
Assigned to

Status

()

Bugzilla
Administration
--
trivial
5 years ago
4 years ago

People

(Reporter: sjoshi, Assigned: sjoshi)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Steps:
1. Click on Classification
2. Click on reclassify of any classification
3. Try to add any product by clicking on add button

Actual result:
No Confirmation message.

Expected result:
Confirmation message should be there.

Comment 1

5 years ago
If you click "Add", then you want to add the product. This doesn't need confirmation.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → INVALID
(Assignee)

Comment 2

5 years ago
I do not agree with this, user always knows what he is doing then why other pages have confirmation messages.

Also there is no submit button in this page which is AFAIK unique to this page only.
Which makes this page more confusing, clicking on Add button actually Submits the page for updation. 

Rest other pages in which we have like this "Add remove functionality" has a explicit "Submit Button" e.g. Change columns, editflags etc.

Consistency should be maintained in any case throughout the application.
Status: RESOLVED → UNCONFIRMED
Resolution: INVALID → ---

Comment 3

5 years ago
Please list other pages that have confirmation messages.

Comment 4

5 years ago
By "confirmation messages", do you mean having an intermediate page asking the user to confirm the changes (which we have nowhere else) or the green message at the top of the page telling you that changes have been saved? Your initial comment sounds like the first one, which is invalid/wontfix.
(Assignee)

Comment 5

5 years ago
I meant "the green message at the top of the page telling you that changes have been saved?"...

Comment 6

5 years ago
OK, now it's clearer.
Severity: normal → trivial
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 7 → All
Hardware: x86_64 → All
(Assignee)

Comment 7

5 years ago
Created attachment 680683 [details] [diff] [review]
Patch-v1
Attachment #680683 - Flags: review?(LpSolit)

Comment 8

5 years ago
Comment on attachment 680683 [details] [diff] [review]
Patch-v1

>=== modified file 'editclassifications.cgi'

>+            $vars->{'message'} = 'reclassification_add_products';

If you select no product to reclassify, then this message is wrong.


>+            $vars->{'message'} = 'reclassification_remove_products';

Same here.



>=== modified file 'template/en/default/global/messages.html.tmpl'

>+  [% ELSIF message_tag == "reclassification_add_products" %]
>+    Product(s) has been addded to <em>[% classification.name FILTER html %]</em> classification.
>+    
>+  [% ELSIF message_tag == "reclassification_remove_products" %]
>+    Product(s) has been removed from <em>[% classification.name FILTER html %]</em> classification.

It's easy to get the list of products which have been reclassified, so your messages should be more useful than that: if no products have been selected, say that there has been no changes. Else list the products which have been reclassified.
Attachment #680683 - Flags: review?(LpSolit) → review-
(Assignee)

Updated

4 years ago
Assignee: administration → joshi_sunil
You need to log in before you can comment on or make changes to this bug.