807431 - [Phone] Final Ringtones Need to be Added to the Build

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect, P1)

Comment 1

[Patryk Adamczyk [:patryk] UX]

Finalized ringtones need to be added to builds.

Comment 2

[Patryk Adamczyk [:patryk] UX]

Also these address the bug that the current OGG ringtones may not play as they are over 48khz.

Comment 3

[Patryk Adamczyk [:patryk] UX]

https://github.com/mozilla-b2g/gaia/pull/6140

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

This made builds too large to flash onto phones so I had to back it out

https://github.com/mozilla-b2g/gaia/commit/62df14acb9a00979b8ab87d4872d33ca7e942f1c

See bug 807851.

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

From bug 807851

Overweight apps are

16M	./webapps/keyboard.gaiamobile.org
11M	./webapps/sms.gaiamobile.org
10M	./webapps/settings.gaiamobile.org
11M	./webapps/communications.gaiamobile.org

Two problems
 - many of these ringtones are HUGE.  One is almost 3MB.
 - they seemed to be copied verbatim into three different locations

Questions
 - why are the ringtones so huge?
 - why are they copied into three locations?
 - why does SMS have ringtones?
 - can we store them on the SD card?

Comment 6

[Faramarz Rashed]

we do need these ringtones but need to make sure they're proper format and placed in the right structure.  :timdream can you make sure this is owned by someone in your team please?

Comment 7

[Patryk Adamczyk [:patryk] UX]

It appears that if an app is using an asset it needs to be placed within that app, I followed how they were coded initially and just did an asset swap. 

A few months ago I advocated for 1 common resource library, but it was out of scope for v.1. Would be great if we could add that in.

A few ringtones are long, as they are a tune.
1. What should happen, is that settings shouldn't require a copy of the ringtones and notifications.

2. There should be a common folder for audio. Where the ringtones and notifications sit. I am okay with them being on the SD Card.

Comment 8

[Ralph Giles (:rillian)]

Some of the ringtones were encoded at over 200 kbps, which is excessive for something normally played out of a phone speaker.

The should certainly be shared, but if you give me the originals, patryk, I can find more optimal settings for them.

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Faramarz (:faramarz) from comment #6)
> we do need these ringtones but need to make sure they're proper format and
> placed in the right structure.  :timdream can you make sure this is owned by
> someone in your team please?

Rex, can you take this?

Comment 10

[Patryk Adamczyk [:patryk] UX]

(In reply to Ralph Giles (:rillian) from comment #8)
> Some of the ringtones were encoded at over 200 kbps, which is excessive for
> something normally played out of a phone speaker.
> 
> The should certainly be shared, but if you give me the originals, patryk, I
> can find more optimal settings for them.

We still need to optimize them (bring them down in size), but they also need to start being beta tested (b2g test drivers), and any audio tweaks made if necessary and then optimized. Realistically people will be using mp3s at high bitrates as ringtones as well so these would be a good stress.

I will provide smaller ringtones later in the week.

Comment 11

[Patryk Adamczyk [:patryk] UX]

(In reply to Ralph Giles (:rillian) from comment #8)
> Some of the ringtones were encoded at over 200 kbps, which is excessive for
> something normally played out of a phone speaker.
> 
> The should certainly be shared, but if you give me the originals, patryk, I
> can find more optimal settings for them.

Hey Ralph, here are the WAVs https://www.dropbox.com/sh/jwbzgka6v633i1q/Dz06fKq0eu the OGG files are encoded in VBR, the vendor has done work in various mobile platforms before and has optimized them for the phone speaker, however he believes that going below 160kps will create noticeable digital artifacts. I can get him to re-tune some of the files, but if you can work your magic and compress them further without impacting the quality, please try. 

And yes, the phone speaker can be poor, but many phone today have great speakers, there are also docks and headphones, so I'd want them to sound decent with all outputs.

Comment 12

[Patryk Adamczyk [:patryk] UX]

Attachment: Default Ringtone & Notifier

Comment 13

[Patryk Adamczyk [:patryk] UX]

I added the default ringtone (Classic Courier) and notifier (Exclamation). Can you please add these into the builds. The rest of the ringtones / notifications should be loaded onto the SD card but should not be read/previewed in the MUSIC app.

Comment 14

[David Flanagan [:djf]]

Chris,

About overweight apps, I think we can reduce the keyboard size if we take out the Japanese input method. It has a huge JSON dictionary. But we need to put in other european dictionaries, so that won't free up much space overall.

More relevant to this bug: how in the world can the set of built-in ringtone options be stored on the sdcard? We don't have any installation or update mechanism for that do we? Are the phones going to be manufactured and sold with an sdcard pre-installed with ringtones on it?  What if the user upgrades to a bigger card? They lose their ring tones? And the relevant apps are presumably written to use URLs for loading the ringtones, not device storage. And making the music app not play ringtones is another wrinkle

I can't imagine any way that sd card storage makes sense for these files. Maybe I'm missing something big, but I'd say that the sd card is not an option here.

Comment 15

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Before we get too deep into this, maybe someone can answer the questions in comment 5?

Comment 16

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Please handle the overall oversizing issue in another bug, in the main time:

(In reply to Chris Jones [:cjones] [:warhammer] from comment #15)
> Before we get too deep into this, maybe someone can answer the questions in
> comment 5?

(In reply to Chris Jones [:cjones] [:warhammer] from comment #5)
> Two problems
>  - many of these ringtones are HUGE.  One is almost 3MB.
>  - they seemed to be copied verbatim into three different locations
> 
> Questions
>  - why are the ringtones so huge?

I guess bug 704993 prevent us from choosing sensible bit rate?

>  - why are they copied into three locations?

Because they all need to play the tone in their pickers (or sound the actual alarm/notification)

>  - why does SMS have ringtones?

New SMS notification is sound by SMS app itself

>  - can we store them on the SD card?

We could put the sound into device storage; but the v1 production requirement doesn't require that, and brings other issues (Do we want to distinguish ringtones vs music? How? How should sound picker works?)

Comment 17

[Ralph Giles (:rillian)]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #16)

> >  - why are the ringtones so huge?
> 
> I guess bug 704993 prevent us from choosing sensible bit rate?

No, the effect is the other direction: the work-around for bug 704993 makes the files smaller. :)

The files are large because we want to support high quality output, as per comment #11, and some of the files are tens of seconds long. Although the files patryk posted are all mono, which helps quite a bit.

Comment 18

[Ralph Giles (:rillian)]

(In reply to Patryk Adamczyk [:patryk] UX from comment #11)

> https://www.dropbox.com/sh/jwbzgka6v633i1q/Dz06fKq0eu

Thanks for posting lossless versions. There are a lot of files, so hand tuning each one would take a few days. However, as a baseline here's the set run through oggenc with the default -q 3, which comes to 4.8 MB altogether. That's still a considerable improvement.

  http://people.mozilla.org/~rgiles/2012/ringtones_48kHz_mono_ogg.zip

I did spot checks on about 20% of the encodes with my good headphones, and they were all transparent to me. Bitrates vary between 40 and 150 kbps, depending on the content, which seems about right for mostly-simple, mono ogg.

Comment 19

[Patryk Adamczyk [:patryk] UX]

Talked to Chris Jones, and I'll resubmit the optimized ringtones / notifications when they are ready. Thanks for Ralph it should reduce them by 60% in size, which will not break the build.

Since we don't have a the SD card as part of the v1 production requirement, we'll opt to store them on device.

Comment 20

[Patryk Adamczyk [:patryk] UX]

I'll also get Chris Jone to merge my commit, so he can scrutinize it for stability.

Comment 21

[Andrew Overholt [:overholt]]

How are things going, Patryk?

Comment 22

[Ralph Giles (:rillian)]

I got busy with other things, so I haven't gotten the optimized opus versions to Patryk. He should have them by the weekend.

Comment 23

[JP Rosevear [:jpr]]

Removing the needinfo.

Comment 24

[JP Rosevear [:jpr]]

Assigning to rillian for now, because he has the next step.

Comment 25

[Ralph Giles (:rillian)]

Attachment: compressed tones, bins 1-3

Patryk, here are optimized versions of your first three bins, totaling 2.4 MB on disk.

These are minimum-bitrate encodes as opus or ogg, whichever gave the best results. They're based on informal comparison against the original. If necessary I could save several more 100KB while still sounding good to anyone not directly comparing with the original.

Comment 26

[Patryk Adamczyk [:patryk] UX]

Attachment: FInal Compressed Sounds from Ralph

Attached are the final compressed sounds... there a LARGE savings. Can you please add the ringtones and notification sounds to the settings panel. There is also an opportunity to replace the sounds in the alarm clock to save space.

Attached in the zip is an HTML file with all the names which the user should see... in the notification selection menu the user should see "notifier_exclamation.ogg" displayed as "Exclamation"

The default notification sound should be "Bell" and the default ringer should be "Classic Courier"

Also if anyone ever needs sounds they can be grabbed from here: https://www.dropbox.com/sh/bczd91l9e0xilr9/Ro6L3ydODJ

Comment 27

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Assigning to Kaze since we have plans to have a custom/ folder and a shared place for those ringtones and this will part of it.

Comment 28

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Comment 29

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Vivien Nicolas (:vingtetun) from comment #28)
> Created attachment 688925 [details] [diff] [review]
> Patch

On my local branch I have also fix a small regression I have found with the clock app.

Comment 30

[Fabien Cazenave [:kaze]]

Comment on attachment 688925 [details] [diff] [review]
Patch

Looks fine to me, please open a PR including all media files — or merge this patch yourself. ;-)

Comment 31

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/9b2cdf4c25dfc1da496d22a0328b6af24307008e

Comment 32

[Fabien Cazenave [:kaze]]

Attachment: follow-up

Just fixing a small diff mistake.

Comment 33

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 689693 [details] [diff] [review]
follow-up

Sigh. thanks!

Comment 34

[Fabien Cazenave [:kaze]]

https://github.com/mozilla-b2g/gaia/commit/ffde69196fa583e61e23a70b2578bb990c18fe64

Comment 35

[Patryk Adamczyk [:patryk] UX]

I am re-opening this bug, as yes, the final ringtones have been added, but the the default tones are incorrect, not sure how that was missed as its part of comment 26 (same comment that added the final tones).

Currently the default ringer is: "Classic Prism", and notification is "Ring"

The ringer should be: "Classic Courier" and the notification should be "Bell"

Comment 36

[Patryk Adamczyk [:patryk] UX]

I am re-opening this bug, and yes, the final ringtones have been added, but the the default tones are incorrect, not sure how that was missed as its part of comment 26 (same comment that added the final tones).

Currently the default ringer is: "Classic Prism", and notification is "Ring"

The ringer should be: "Classic Courier" and the notification should be "Bell"

Comment 37

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Followup

Comment 38

[Alexandre Poirot [:ochameau]]

Comment on attachment 692962 [details] [diff] [review]
Followup

Tested, works fine.

Comment 39

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/74f6107ad865102abdecd7d130be891298dec42a

Comment 40

[Tony Chung [:tchung]]

vivien, how can i test this patch?  on the 1-2 build, i see both classic prism and classic courier options in the sound settings.

Comment 41

[Natalya Kot [:nkot]]

Fix verified on 1-3 build

Unagi Build ID:20130103070201 - default settings: the ringer "Classic Courier" and the notification "Bell"