807500 - Add the minimum set of required GL methods to GLContext for Skia/Ganesh use

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[George Wright (:gw280) (needinfo me!)]

For some reason, this isn't in GLContext. Despite Benoit's claims, it is in the GLES2 spec. The function is required by Ganesh.

Comment 1

[Oleg Romashin (:romaxa)]

I think it would make sense to specify which functionality require that, or depended bug.

Comment 2

[George Wright (:gw280) (needinfo me!)]

Attachment: Add a bunch of required GL wrapper methods for Skia

Ganesh needs a whole whack of additional GL methods on the GLContext class. I think this is the minimum set required.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 708881 [details] [diff] [review]
Add a bunch of required GL wrapper methods for Skia

GetTexParameteriv is identical to GetTexParameteri on ES (I guess without some extensions), but sure.

Query stuff is definitely in extensions on ES -- they may not always be present.  Likewise DrawBuffer[s]. (that's MRT)  We'll need to do something about those.

Comment 4

[George Wright (:gw280) (needinfo me!)]

Query/Buffers are only used on desktop and so the symbols are only added in the if (desktop) block.

Comment 5

[George Wright (:gw280) (needinfo me!)]

https://mxr.mozilla.org/mozilla-central/source/gfx/skia/src/gpu/gl/GrGLInterface.cpp is the relevant file in Skia that states which GL functions are required on which configurations.

Comment 6

[George Wright (:gw280) (needinfo me!)]

Comment on attachment 708881 [details] [diff] [review]
Add a bunch of required GL wrapper methods for Skia

Switching to Benoit as Jeff is apparently travelling atm.

Comment 7

[George Wright (:gw280) (needinfo me!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9441307a79de

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9441307a79de