The default bug view has changed. See this FAQ.

Sanitize dialog ("Clear Recent History") cleanup: unused strings

RESOLVED FIXED in Thunderbird 23.0

Status

Thunderbird
Mail Window Front End
--
minor
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: aryx, Assigned: Cykesiopka)

Tracking

17 Branch
Thunderbird 23.0
x86
Windows XP

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Thunderbird 17.0 Beta (buildid 20121030125442) on Windows XP SP3 32 bit

The "Clear Recent History" menu item in the "Tools" menu launches a dialog.

There are some issues which are small and can all be fixed in one patch:

1. The accesskeys and the listbox don't work, either make me them work or remove them: http://hg.mozilla.org/releases/comm-beta/diff/76efc33d143a/mail/base/content/sanitize.xul

2. There are unused strings, use them or remove them:

<!ENTITY sanitizePrefs2.title          "Settings for Clearing History">

<!ENTITY sanitizeItems.label "Clear the following items now:"> (this one is also not used in /browser/)
<!ENTITY clearDataSettings2.label "When I quit &brandShortName;, it should automatically clear all:">

<!ENTITY clearTimeDuration.dateColumn "Visit Date">
<!ENTITY clearTimeDuration.nameColumn "Name">

<!ENTITY historySection.label         "History">
<!ENTITY dataSection.label            "Data">
perhaps a different bug, but does this really even deserve to be in a thunderbird menu?
Component: General → Mail Window Front End
(Assignee)

Comment 2

4 years ago
Created attachment 744972 [details] [diff] [review]
Proposed Part 1: String Removal v1

I have no idea what to do about the listbox or the access keys, so just the string removal part for now...
Attachment #744972 - Flags: review?(mbanner)
(In reply to Wayne Mery (:wsmwk) from comment #1)
> perhaps a different bug, but does this really even deserve to be in a
> thunderbird menu?

Yes, it was a requirement from the privacy folks/review.
Comment on attachment 744972 [details] [diff] [review]
Proposed Part 1: String Removal v1

Looks great, r=Standard8.

At a quick glance, I don't see why the access keys wouldn't work and Firefox has the same issue as well. I suggest we file a core bug on the access keys issue, and close this one (once the patch has landed) as the removing unused strings.
Attachment #744972 - Flags: review?(mbanner) → review+
(Assignee)

Comment 5

4 years ago
Created attachment 747157 [details] [diff] [review]
Patch for check in

I changed the commit message so it doesn't mention "Part 1" anymore, as this bug is now only about the string removal.
Assignee: nobody → cykesiopka.bmo
Attachment #744972 - Attachment is obsolete: true
Status: NEW → ASSIGNED
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
Summary: Sanitize dialog ("Clear Recent History") cleanup: unused strings, inaccessible accesskeys → Sanitize dialog ("Clear Recent History") cleanup: unused strings
https://hg.mozilla.org/comm-central/rev/d7c72b841e66
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 23.0
(Assignee)

Comment 7

4 years ago
(In reply to Mark Banner (:standard8) from comment #4)
> I suggest we file a core bug on the access keys issue

I filed Bug 870615 for this.
You need to log in before you can comment on or make changes to this bug.