Closed Bug 807699 Opened 8 years ago Closed 8 years ago
Sanitize dialog ("Clear Recent History") cleanup: unused strings
Thunderbird 17.0 Beta (buildid 20121030125442) on Windows XP SP3 32 bit The "Clear Recent History" menu item in the "Tools" menu launches a dialog. There are some issues which are small and can all be fixed in one patch: 1. The accesskeys and the listbox don't work, either make me them work or remove them: http://hg.mozilla.org/releases/comm-beta/diff/76efc33d143a/mail/base/content/sanitize.xul 2. There are unused strings, use them or remove them: <!ENTITY sanitizePrefs2.title "Settings for Clearing History"> <!ENTITY sanitizeItems.label "Clear the following items now:"> (this one is also not used in /browser/) <!ENTITY clearDataSettings2.label "When I quit &brandShortName;, it should automatically clear all:"> <!ENTITY clearTimeDuration.dateColumn "Visit Date"> <!ENTITY clearTimeDuration.nameColumn "Name"> <!ENTITY historySection.label "History"> <!ENTITY dataSection.label "Data">
perhaps a different bug, but does this really even deserve to be in a thunderbird menu?
I have no idea what to do about the listbox or the access keys, so just the string removal part for now...
Attachment #744972 - Flags: review?(mbanner)
(In reply to Wayne Mery (:wsmwk) from comment #1) > perhaps a different bug, but does this really even deserve to be in a > thunderbird menu? Yes, it was a requirement from the privacy folks/review.
Comment on attachment 744972 [details] [diff] [review] Proposed Part 1: String Removal v1 Looks great, r=Standard8. At a quick glance, I don't see why the access keys wouldn't work and Firefox has the same issue as well. I suggest we file a core bug on the access keys issue, and close this one (once the patch has landed) as the removing unused strings.
Attachment #744972 - Flags: review?(mbanner) → review+
I changed the commit message so it doesn't mention "Part 1" anymore, as this bug is now only about the string removal.
Assignee: nobody → cykesiopka.bmo
Attachment #744972 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Summary: Sanitize dialog ("Clear Recent History") cleanup: unused strings, inaccessible accesskeys → Sanitize dialog ("Clear Recent History") cleanup: unused strings
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 23.0
(In reply to Mark Banner (:standard8) from comment #4) > I suggest we file a core bug on the access keys issue I filed Bug 870615 for this.
You need to log in before you can comment on or make changes to this bug.