807715 - BaselineCompiler: support arguments

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

Attachment: Patch

I was working on cleaning up/documenting the frame layout and some basic support for arguments helps test some assumptions.

Comment 1

[Kannan Vijayan [:djvj]]

Comment on attachment 677463 [details] [diff] [review]
Patch

Review of attachment 677463 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/BaselineFrameInfo.h
@@ +189,5 @@
> +    uint32_t nlocals() const {
> +        return script->nfixed;
> +    }
> +    uint32_t nargs() const {
> +        return script->function()->nargs;

We probably want to JS_ASSERT that the script has a function - to ensure that nargs() never gets called inadvertently for compilations of top-level scripts.

Comment 2

[Jan de Mooij [:jandem]]

Pushed (we usually don't assert non-NULL right before a dereference since it's going to crash immediately).

http://hg.mozilla.org/projects/ionmonkey/rev/6968bdb0417b