If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Properly unit test Bouncer

VERIFIED FIXED

Status

Webtools
Bouncer
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: brandon, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
Presently, Bouncer has a few tests in terms of the admin UI(python tests) and some tests for the database abstraction layer, but there's little testing on the bouncer functionality itself. It's important that QA's automation tests and manual verifications not be the only method of determining whether or not a change has broken Bouncer. 

This bug is intended to track the discussion and construction of tests to do the following:

* Appropriately test the custom code in the Tuxedo admin UI
* Appropriately test the bouncer code
* Test bouncer's components and custom libraries

The scope of work in this involves getting the existing tests running, determining the code coverage and functionality tested, correcting tests that fail due to code changes that were not reflected in the test code, and addition of new tests to the various areas along with the new features.

Updated

5 years ago
OS: Mac OS X → All
Hardware: x86 → All
Blocks: 804347
(Reporter)

Comment 1

5 years ago
I've decided to use PHPUnit for this, but getting the dependencies right for packaging PHPUnit is non-trivial. I've decided to go with using PEAR installation of PHPUnit. I've also modified the code to make it testable, the next step being to actually write the tests.
(Reporter)

Updated

5 years ago
Depends on: 800194
(Reporter)

Updated

5 years ago
No longer blocks: 804347
(Reporter)

Comment 2

5 years ago
This is completed. There are tests for bouncer. More can stand to be added as the code changes.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Thanks Brandon! This is fantastic news - test coverage ftw. Can you provide an url to the test code? Also what env are the tests running in and how often are they run?
Flags: needinfo?(bsavage)
(Reporter)

Comment 4

5 years ago
These tests run against the developer code, and aren't part of integration. They're run before every commit.
Flags: needinfo?(bsavage)
Bumping to verified per comment and comment 4. Thanks again Brandon. Woot
Status: RESOLVED → VERIFIED
(Reporter)

Comment 6

5 years ago
Tests live in the https://github.com/mozilla/tuxedo repository alongisde the bouncer code.
You need to log in before you can comment on or make changes to this bug.