Folder pane (tree widget) on linux wastes horizontal space

RESOLVED FIXED in Thunderbird 19.0

Status

Thunderbird
Folder and Message Lists
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: protz, Assigned: Paenglab)

Tracking

({regression})

Trunk
Thunderbird 19.0
x86_64
Linux
regression

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 2 obsolete attachments)

(Reporter)

Description

5 years ago
Created attachment 677544 [details]
Before

(I was sure I filed this a year ago but apparently I forgot to do it -- I'm feeling the pain now that I'll be running without my 24'' monitor for a few weeks).

Approximately a year ago, Thunderbird started using a whole lot more horizontal space for its folder tree, namely around the icon and left of the label. I'm attaching two screenshots for comparison.

I'm using a vertical layout on a 1600x1050 screen, so this kinda wastes space, both in the folder list and the thread pane (thread triangles waste the same amount of space).

Any idea what can cause this?
(Reporter)

Comment 1

5 years ago
Created attachment 677545 [details]
After
(Reporter)

Comment 2

5 years ago
Richard, I'm CCing you because as the theme expert you may have ideas :). If you think this is not Thunderbird-related (this may well be the case) feel free to reassign to Core/XUL.
Summary: Folder on linux wastes awful amount of horizontal space → Folder pane (tree widget) on linux wastes horizontal space
(Assignee)

Comment 3

5 years ago
Bug 689543 introduced a 5px margin before the label. I'll try to fix this.
Assignee: nobody → richard.marti
(Reporter)

Comment 4

5 years ago
Oh that would be fantastic!
(Assignee)

Comment 5

5 years ago
Created attachment 677720 [details] [diff] [review]
patch

I gave the cell-text in the folder pane a padding of 1px to have still a small gap between icon and text.
Attachment #677720 - Flags: ui-review?(bugs)
Attachment #677720 - Flags: review?(bugs)
Blocks: 689543
Severity: normal → minor
Keywords: regression
(Reporter)

Comment 6

5 years ago
Thinking about it, do we also need the extra space between the tree twisty and the subject?

http://jonathan.protzenko.free.fr/shutter/Selection_042.png

I feel like we would benefit from removing the space left of the "[" brackets (as seen in the screenshot) but there may be a good reason not to do so. I guess it really is a matter of personal preference, so please take my question as begin a curious "why are we doing it that way?" rather than a "I think we should change this!" sort of thing :).
(Reporter)

Comment 7

5 years ago
Oh and I found the answer myself, we need the space for the "replied to / forwarded" icons :)
Comment on attachment 677720 [details] [diff] [review]
patch

This looks more crowded. I agree that we can decrease the spacing some, but not this much. It also seems to break folders with new messages in them. See attached screenshot.
Attachment #677720 - Flags: ui-review?(bugs)
Attachment #677720 - Flags: ui-review-
Attachment #677720 - Flags: review?(bugs)
Attachment #677720 - Flags: review-
Created attachment 678709 [details]
text overflows all folders with new messages

This is a catch-all-address for a certain domain, so a lot of unread spam :)
(Assignee)

Comment 10

5 years ago
(In reply to Andreas Nilsson (:andreasn) from comment #8)
> Comment on attachment 677720 [details] [diff] [review]
> patch
> 
> This looks more crowded. I agree that we can decrease the spacing some, but
> not this much. It also seems to break folders with new messages in them. See
> attached screenshot.

Oops, then the new message rule needs also a padding change.

Would be 2px for spacing better? Then we have gained 3px.
That sounds good to me!
(Assignee)

Comment 12

5 years ago
Created attachment 678774 [details] [diff] [review]
patch v2

Now with correct new mail display.
Attachment #677720 - Attachment is obsolete: true
Attachment #678774 - Flags: ui-review?(bugs)
Attachment #678774 - Flags: review?(bugs)
padding-left: 18px !important; on 244
How come it needs !important here? Always good to avoid !important if possible.
Comment on attachment 678774 [details] [diff] [review]
patch v2

ui looks good!
Attachment #678774 - Flags: ui-review?(bugs) → ui-review+
(Assignee)

Comment 15

5 years ago
Created attachment 679229 [details] [diff] [review]
patch v3

Now without !important.

Carrying over ui-r+
Attachment #678774 - Attachment is obsolete: true
Attachment #678774 - Flags: review?(bugs)
Attachment #679229 - Flags: ui-review+
Attachment #679229 - Flags: review?(bugs)
Comment on attachment 679229 [details] [diff] [review]
patch v3

Thanks for getting rid of the !important
Attachment #679229 - Flags: review?(bugs) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/8dbefac39d8c
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 19.0
You need to log in before you can comment on or make changes to this bug.