Created attachment 677544 [details]
(I was sure I filed this a year ago but apparently I forgot to do it -- I'm feeling the pain now that I'll be running without my 24'' monitor for a few weeks).
Approximately a year ago, Thunderbird started using a whole lot more horizontal space for its folder tree, namely around the icon and left of the label. I'm attaching two screenshots for comparison.
I'm using a vertical layout on a 1600x1050 screen, so this kinda wastes space, both in the folder list and the thread pane (thread triangles waste the same amount of space).
Any idea what can cause this?
Created attachment 677545 [details]
Richard, I'm CCing you because as the theme expert you may have ideas :). If you think this is not Thunderbird-related (this may well be the case) feel free to reassign to Core/XUL.
Bug 689543 introduced a 5px margin before the label. I'll try to fix this.
Oh that would be fantastic!
Created attachment 677720 [details] [diff] [review]
I gave the cell-text in the folder pane a padding of 1px to have still a small gap between icon and text.
Thinking about it, do we also need the extra space between the tree twisty and the subject?
I feel like we would benefit from removing the space left of the "[" brackets (as seen in the screenshot) but there may be a good reason not to do so. I guess it really is a matter of personal preference, so please take my question as begin a curious "why are we doing it that way?" rather than a "I think we should change this!" sort of thing :).
Oh and I found the answer myself, we need the space for the "replied to / forwarded" icons :)
Comment on attachment 677720 [details] [diff] [review]
This looks more crowded. I agree that we can decrease the spacing some, but not this much. It also seems to break folders with new messages in them. See attached screenshot.
Created attachment 678709 [details]
text overflows all folders with new messages
This is a catch-all-address for a certain domain, so a lot of unread spam :)
(In reply to Andreas Nilsson (:andreasn) from comment #8)
> Comment on attachment 677720 [details] [diff] [review]
> This looks more crowded. I agree that we can decrease the spacing some, but
> not this much. It also seems to break folders with new messages in them. See
> attached screenshot.
Oops, then the new message rule needs also a padding change.
Would be 2px for spacing better? Then we have gained 3px.
That sounds good to me!
Created attachment 678774 [details] [diff] [review]
Now with correct new mail display.
padding-left: 18px !important; on 244
How come it needs !important here? Always good to avoid !important if possible.
Comment on attachment 678774 [details] [diff] [review]
ui looks good!
Created attachment 679229 [details] [diff] [review]
Now without !important.
Carrying over ui-r+
Comment on attachment 679229 [details] [diff] [review]
Thanks for getting rid of the !important