Stringify process number in devicemanagerADB

RESOLVED WONTFIX

Status

RESOLVED WONTFIX
6 years ago
8 months ago

People

(Reporter: wesj, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Created attachment 677603 [details] [diff] [review]
Patch

We're not stringify the process name in killProcess. That leads to tests not running.
(Reporter)

Updated

6 years ago
Attachment #677603 - Attachment is patch: true
Attachment #677603 - Flags: review?(jmaher)
Comment on attachment 677603 [details] [diff] [review]
Patch

Review of attachment 677603 [details] [diff] [review]:
-----------------------------------------------------------------

good catch.  We have a few consumers of devicemanagerADB so we need to be careful with this, specifically the Marionette B2G emulator tests.
Attachment #677603 - Flags: review?(jmaher) → review+
(Reporter)

Comment 2

6 years ago
This is apparently checked in on github, but not synced with mc:

https://github.com/mozilla/mozbase/commit/94e9a49155de4a03467a5d68fc5cfec03953bb06
Mass closing mochitest bugs that haven't had activity in the past 5 years. Please re-open or file a new bug with modern context if this is still relevant.
Status: NEW → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.