807878 - crash in nsMsgLocalMailFolder::RefreshSizeOnDisk

Status: RESOLVED WORKSFORME

(MailNews Core :: Backend, defect)

Description

[Wayne Mery (:wsmwk)]

~top 100 crash
crash comments indicate during compact

This bug was filed from the Socorro interface and is 
report bp-20b772a3-f003-43d4-a0f1-1bbd22121009 
============================================================= 
0		@0xfffff9	
1	xul.dll	nsMsgLocalMailFolder::RefreshSizeOnDisk	mailnews/local/src/nsLocalMailFolder.cpp:1131
2	xul.dll	nsMsgLocalMailFolder::OnCopyCompleted	mailnews/local/src/nsLocalMailFolder.cpp:1357
3	xul.dll	nsMsgLocalMailFolder::EndMove	mailnews/local/src/nsLocalMailFolder.cpp:2539
4	xul.dll	nsCopyMessageStreamListener::EndCopy	mailnews/base/src/nsCopyMessageStreamListener.cpp:141
5	xul.dll	nsCopyMessageStreamListener::OnStopRequest	mailnews/base/src/nsCopyMessageStreamListener.cpp:150
6	xul.dll	nsMsgProtocol::OnStopRequest	mailnews/base/util/nsMsgProtocol.cpp:399

Comment 1

[Kent James (:rkent)]

I don't have a solid theory of this crash. My guess though is that one of the observers has been released. My suspicion would be nsMsgSendLater because it adds a folder listener (which is rare, most code uses a session listener) and it does manual releases of itself.

Comment 2

[Wayne Mery (:wsmwk)]

Another regression of TB12 - lilke bug 818325.
But unclear whether without deeper checking if related to bug 402392 maildir and it's friends like bug 713958 and bug 715924

Note, there are multiple stacks. Two examples

bp-1a30fd5c-6ca6-4f11-a4ee-5f99a2140313 TB12.0.1

0 		@0x29732528	
1 	xul.dll	nsMsgLocalMailFolder::RefreshSizeOnDisk()	mailnews/local/src/nsLocalMailFolder.cpp
2 	xul.dll	nsMsgLocalMailFolder::NotifyCompactCompleted()	mailnews/local/src/nsLocalMailFolder.cpp
3 	xul.dll	nsFolderCompactState::Compact(nsIMsgFolder*, bool, nsIUrlListener*, nsIMsgWindow*)	mailnews/base/src/nsMsgFolderCompactor.cpp
4 	xul.dll	nsMsgBrkMBoxStore::CompactFolder(nsIMsgFolder*, nsIUrlListener*, nsIMsgWindow*)	mailnews/local/src/nsMsgBrkMBoxStore.cpp
5 	xul.dll	nsMsgLocalMailFolder::Compact(nsIUrlListener*, nsIMsgWindow*)	mailnews/local/src/nsLocalMailFolder.cpp 

bp-ebe5951e-fb22-4408-bdd6-087fe2140817 TB31
 0 		@0x4052c000	
1 	xul.dll	nsMsgLocalMailFolder::RefreshSizeOnDisk()	mailnews/local/src/nsLocalMailFolder.cpp
2 	xul.dll	nsMsgLocalMailFolder::UpdateFolder(nsIMsgWindow*)	mailnews/local/src/nsLocalMailFolder.cpp
3 	xul.dll	NS_InvokeByIndex	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp
 
http://hg.mozilla.org/releases/comm-esr31/annotate/6219e5a9a8d8/mailnews/local/src/nsLocalMailFolder.cpp#l1108
ehsan@13324 1105 uint32_t oldFolderSize = mFolderSize;
hg@0 1106 mFolderSize = 0; // we set this to 0 to force it to get recalculated from disk
hg@0 1107 if (NS_SUCCEEDED(GetSizeOnDisk(&mFolderSize)))
hg@0 1108   NotifyIntPropertyChanged(kFolderSizeAtom, oldFolderSize, mFolderSize);

Comment 3

[Wayne Mery (:wsmwk)]

This might be optimistic, but so far there are no version 68 crashes
https://crash-stats.mozilla.org/search/?signature=~nsMsgLocalMailFolder%3A%3ARefreshSizeOnDisk&product=Thunderbird&date=%3E%3D2019-07-05T12%3A03%3A00.000Z&date=%3C2020-01-05T12%3A03%3A00.000Z&_facets=signature&_sort=-date&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#crash-reports