807904 - [system app] modal dialog supports given title and text as dialog content.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P1)

Description

[Evelyn Hung]

For SIM PIN unlock pop up dialog UI (see http://people.mozilla.com/~lco/Settings_B2G/Release_1_Specs/R1_Security_and_Privacy_v3.pdf page 18), we need modal dialog to support title and text as its parameters, so we can layout content like UX specified.

Comment 1

[Josh Carpenter [:jcarpenter]]

Can you clarify? Current dialogue implementation already allows defining title and body strings.

Comment 2

[Evelyn Hung]

According to Alive's implementation in System app, modal dialog only allows a string as its content body, like window.confirm dialog.

Because this probably will block bug 804966 if we still need this dialog prompts before trigger SIM PIN unlock process, this bug should be bb+.

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

I think Josh is talking about Custom Dialog, which is used at update manager.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

ochameau, would you like to use modal dialog in system app or custom dialog in building block?

Comment 5

[Alexandre Poirot [:ochameau]]

I just jumped into this feature today and it isn't really clear what should I do.
So far, I'd say I'll need to implement a new dedicated dialog for SIM PIN.
Something like what has been done for HTTP authentification:
  https://github.com/mozilla-b2g/gaia/blob/master/apps/system/index.html#L367-388
Such way of doing would not require anything special to be done.

Having said that, I'm only taking care of bug 804966 right now (webactivity removal).
Evelyn pointed out  http://people.mozilla.com/~lco/Settings_B2G/Release_1_Specs/R1_Security_and_Privacy_v3.pdf page 18, where there is some new UI to be added. These additions may require such new Dialogs tweaks?

In order to unblock bug 794407 and remove the WebActivity ASAP, I'm not planning to do that in bug 804966, but in an eventual followup if we consider a UI/UX change is bb+.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: PR 6335

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 680246 [details]
PR 6335

r=me. Please test it and merge it yourself, Thanks!

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/commit/2eab4d98c642902c4484f23efa93f77036accc60

Tested with SIM PIN prompt.