808141 - Wi-Fi shows "offline" whereas it should be "Not connected"

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Larissa Co [:lco]]

The subtitle text (the text beneath the headings in the settings list) isn't consistent right now. This is an extremely important polish step (we really look unprofessional without it and it isn't a lot of engineering effort, I hope.)

The standard format should be:
1. First letter of the first word capitalized
2. No period at the end
3. Titles (networks, wi-fi SSIDs etc) should be capitalized

So far, I see this bug only for the Wi-Fi subtitle:
1. "connected to <network>." should be "Connected to <Network>"
2. "offline." should be "Offline"

Comment 1

[Larissa Co [:lco]]

actually, I also realized that I don't know what state "Offline" refers to. If it refers to the state where the user is not connected to any network, and there are networks available, the string should say "Not connected" instead.

If this is the case, I can file an additional bug.

Comment 2

[[e-mail]]

Need some UX　love

Comment 3

[Tina Hsieh[:Tina_Hsieh] UX]

Here is the spec of Building Blocks (Web Component). The guideline of writing style is right in this spec:
https://mozilla.app.box.com/files/0/f/1873727047/1/f_18801246290

In 2.5, the writing style of titles and sub-titles are both correct in Wi-Fi setting. However, there are still plenty of inconsistencies in settings. Let's keep making things right.

About the string issue, @ Matej Can you give us a suggestion?

Comment 4

[Matej Novak [:matej]]

(In reply to Tina Hsieh[:Tina_Hsieh] UX from comment #3)
> Here is the spec of Building Blocks (Web Component). The guideline of
> writing style is right in this spec:
> https://mozilla.app.box.com/files/0/f/1873727047/1/f_18801246290
> 
> In 2.5, the writing style of titles and sub-titles are both correct in Wi-Fi
> setting. However, there are still plenty of inconsistencies in settings.
> Let's keep making things right.
> 
> About the string issue, @ Matej Can you give us a suggestion?

I don't see anything at the above link. Can you let me know which string you need me to review? Thanks.

Comment 5

[Tina Hsieh[:Tina_Hsieh] UX]

@Larissa suggested that the "Offline" in Wi-Fi setting may replace by "Not connected" because of certain confusing issue with "Offline". 

Can you give us some suggestions about these strings? Thank you for the review. :)

Comment 6

[[e-mail]]

might be here 
https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/locales/settings.en-US.properties#L62

Comment 7

[[e-mail]]

Seems the capital issue is resolved, the only issue left is 'Offline' or 'Not connected'

Comment 8

[Matej Novak [:matej]]

(In reply to Fred Lin [:gasolin] from comment #7)
> Seems the capital issue is resolved, the only issue left is 'Offline' or
> 'Not connected'

I'm not aware of any specific issue with using "Offline," but "Not connected" looks more consistent with other strings, so let's go with that.

Comment 10

[[e-mail]]

Need change fullStatus-disconnected & shortStatus-disconnected and rename these identifier with other name (should replace in html as well) to help l10n team find the string change

https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/locales/settings.en-US.properties#L63

Comment 11

[Ray Lin[:ralin]]

Hello!

I'd like to be assigned to this bug, if possible. Thanks

Comment 12

[[e-mail]]

of course!

Comment 13

[GitHub Autolander Bot]

Attachment: [gaia] raylin:808141-wifi-status > mozilla-b2g:master

Comment 14

[Ray Lin[:ralin]]

Comment on attachment 8681871 [details] [review]
[gaia] raylin:808141-wifi-status > mozilla-b2g:master

1. replaced 'Offline' with 'Not connected' and changed IDs' prefix in locales.
2. updated few related js files to make l10n-id correspond to new IDs.

Test failed at communications-contacts/test/unit/bootstrap_test.js, but I not sure it is about this commit or not.

Comment 15

[[e-mail]]

Comment on attachment 8681871 [details] [review]
[gaia] raylin:808141-wifi-status > mozilla-b2g:master

Looks good, thanks.

Since this is just string change in settings, the test error seems not related

Comment 16

[[e-mail]]

merged https://github.com/mozilla-b2g/gaia/commit/079ead4487841d3e5168501e7218f082ced83c61