[Contacts] "Delete contact" confirmation buttons ("Cancel|Remove") are misaligned

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dholbert, Unassigned)

Tracking

({b2g-testdriver, polish, unagi})

unspecified
x86_64
Linux
b2g-testdriver, polish, unagi

Firefox Tracking Flags

(blocking-basecamp:-)

Details

(Whiteboard: [qa+])

Attachments

(1 attachment)

Created attachment 677881 [details]
screenshot

STR:
 1. View a contact in Contacts App
 2. Select Edit button in upper-right corner
 3. Scroll all the way down, and hit "Delete contact"

ACTUAL RESULTS: The buttons at the bottom of the confirmation dialog are misaligned, looking like this (exaggerated a bit, due to limitations of ASCII art):

  __________
 |          | __________
 |  Cancel  ||          |
 |__________||  Remove  |
             |__________|

EXPECTED RESULTS: The buttons should be aligned.
Summary: [Contacts] "Delete contact" confirmation button ("Remove") is misaligned → [Contacts] "Delete contact" confirmation buttons ("Cancel|Remove") are misaligned
Gaia Triage : - ; it's a polish bug with ui... I think we still would like to see a fix for this before a release.  Marking qa+ so that qa doesn't lose track of it.
blocking-basecamp: ? → -
Keywords: polish
Whiteboard: [qa+]

Updated

6 years ago
Component: Gaia → Gaia::Contacts

Comment 2

6 years ago
try to modify like this can fix this bug.

------------- apps/communications/contacts/style/custom_dialog.css -------------
index 7789c3d..d7b95a8 100644
@@ -101,19 +101,23 @@ body[role="application"] menu:not([type="toolbar"]) button {
   text-decoration: none;
   text-overflow: ellipsis;
   text-shadow: 1px 1px 0 rgba(255, 255, 255, 0.3);
   vertical-align: middle;
   white-space: nowrap;
   width: 100%;
 }
 
 body[role="application"] menu:not([type="toolbar"]):not([data-items="1"]) button:last-child {
   margin-left: 1rem;
 }
 
+body[role="application"] menu:not([type="toolbar"]) button#dialog-no {
+   margin-top:1rem; 
+}
+
 body[role="application"] menu:not([type="toolbar"]) button.negative {
   background-color: #B70404;
   background-image: url("images/ui/negative.png");
   border: medium none;
   color: #FFFFFF;
   text-shadow: -1px -1px 0 #830B0B;
 }

Comment 3

6 years ago
Loving the ASCII "screenshot", BTW :)
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Thanks! :)

But wait -- did you intend to resolve the bug? (I don't see any indication that code was checked in to fix it)

Comment 5

6 years ago
Sorry, forgot the link.

https://bugzilla.mozilla.org/show_bug.cgi?id=811283

Thanks!

Comment 6

6 years ago
I have fix this bug on the branch sprdroid4.0.3_vlx_3.0_b2g. Did I need to merge this modify to master branch? :)
(In reply to Alberto Pastor from comment #5)
> Sorry, forgot the link.
> 
> https://bugzilla.mozilla.org/show_bug.cgi?id=811283

...that's just a link to this bug. :)

Assuming this isn't fixed -- reopening.

(In reply to jian.ma from comment #6)
> I have fix this bug on the branch sprdroid4.0.3_vlx_3.0_b2g. Did I need to
> merge this modify to master branch? :)

(I'm not entirely sure what that means, but I think you need to do a pull request to get this merged into https://github.com/mozilla-b2g/gaia/)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 8

6 years ago
(In reply to Daniel Holbert [:dholbert] from comment #7)
> (In reply to Alberto Pastor from comment #5)
> > Sorry, forgot the link.
> > 
> > https://bugzilla.mozilla.org/show_bug.cgi?id=811283
> 
> ...that's just a link to this bug. :)

Is NOT to this bug :)

current -> 808183
I pointed to -> 811283

This is the Pull Request from the bug I linked  -> https://github.com/mozilla-b2g/gaia/pull/6545

Dialer and Contacts use the same mechanism for Confirmation Dialogs now (which is what the other bug fixed), and there are not misalignments with the new implementation.

Could you please resolve it yourself if you think that's right? Thanks!

Comment 9

6 years ago
(In reply to jian.ma from comment #6)
> I have fix this bug on the branch sprdroid4.0.3_vlx_3.0_b2g. Did I need to
> merge this modify to master branch? :)

Hey Jian! Thanks for your help, but I think this bug is already solved. What you need to do with next bugs is assign yourself, fix it in a branch of your fork, and make a Pull Request to the mozilla-b2g/gaia repository. Let me know if you need help with that!
Ah, I just saw 8***83 and thought it was this bug. :)

Resolving as FIXED w/ dependency on that other bug. Thanks!
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Depends on: 811283
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.