8082 - [RFE] req: Change cancel on "do you want to save this form" no "no" and make yes get disbled when "never save this form" is checked

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Chris Booton]

When you first submit a form it will ask you the usual submitting forms security message via  a small popup, this pop up however appears scrambled and only a check box and an okay and cancel button are seen. If you check the checkbox and press okay , the next time you submit a form the same box will still pop up.

Comment 1

[Chris Booton]

A silight additon, Im using build 1999061208, and in this popup, even if you press the cancel button it will still go forward with the form submission.

Comment 2

[Chris Booton]

It arrears I made a mistake , I thought there was a 'dont show this again'
button, but it was actually the never save this form. Because the window was
'messed up' I could not see it. However now the window is fine. However it seems
as if instead of a cancel button this button should have a No button instead, so
you can have a choice of Yes save this form in wallet, no do not save it.
Obiously you would not be able to select never save it and yes save it at the
same time, but Im unsure how to do this other then if you put the check in never
save it then doing so would disable the yes button. Would it be possible to ad
an onlcik event foe the enever save this form checkbox, so thta onlick it
disables the Yes button, and offcick it enables it? I'm not sure if checking the
dont save this form works or not, I think it does but will check with a simple
form on my page, I write back when I do to see if it works or not.

Comment 3

[Chris Booton]

Confimed it works when you select 'never save this form with the form on my
page' . I believe witht his thta this bug can be marked as worksforme , but
change it to an enhansment request, with what I said earlier about making the
Cancel button say "No" , and making it so that when "never save this form" is
checked that "yes" is disbaled as saying to yes save it but never save is
somewhat paradoxal. I will attach my page witht he form for testing and demo
purposes.

Comment 4

[Chris Booton]

Attachment: my html with form for demo and testing

Comment 5

[Chris Booton]

Changed summary to sugestion as this is what it now is.

Comment 6

[karnaze (gone)]

Reassigning to Steve.

Comment 7

[Stephen P. Morse]

Let me summarize what I think this report is saying.  First, there was a bug
with the pop-up window not being displayed correctly but that has long since
been fixed (I recall when that occurred) so that is no longer an issue.

So what the report is now asking is for two enhancements.

1. Buttons should say YES/NO instead of OK/CANCEL

I agree completely.   I argued for this well over a year ago when I first
started implementing such dialogs.  But our UE (user experience) group argued
back that OK/CANCEL were standard button designations and we therefore had to
use them.  And since the UE group was in charge of what the UI looks like, their
opinion prevailed.  Since the issue is being raised again in this bug report, I
am going to reassing it to German who is in the UE group.

2. YES button should be greyed out if the "never save" checkbox is checked

This is an excellent suggestion from a user interface standpoint.  However, from
an implementation standpoint this would be very difficult to achieve as there is
no infrastructure in place to allow for such a dialog.  So, unless the UE team
takes up the cause and feels that it is imperative for us to grey out the YES
box, this probably will not be implemented.

Comment 8

[cpratt]

I would also suggest that this dialog is a special case: ordinarily, OK and
Cancel should be used, but in this case, it does seem that Yes and No are more
appropriate. Additionally (yes, I know, all you need is another suggestion), it
seems that it would be a Good Thing to also include an option in the dialog box
to turn off the Wallet feature entirely (as IE 5 does).

Comment 9

[Stephen P. Morse]

*** Bug 8158 has been marked as a duplicate of this bug. ***

Comment 10

[Stephen P. Morse]

*** Bug 10057 has been marked as a duplicate of this bug. ***

Comment 11

[Matthew Tuck [:CodeMachine]]

I agree with the Yes/No part, as it stands it is very confusing.  OK/Cancel is
for modal dialog boxes, not question boxes.

I suggest if you can't grey this checkbox, you should make a third button "No,
Never"

Comment 12

[Stephen P. Morse]

*** Bug 11119 has been marked as a duplicate of this bug. ***

Comment 13

[Stephen P. Morse]

OK, since I didn't hear any objections from UE about this, I decided to make my
own decision and go with the YES/NO instead of OK/CANCEL.  This applies in
several other wallet dialogs as well and also in the cookie nag box.  I just
checked in the changes so I'm closing out this report as fixed.

Comment 14

[cpratt]

morse, good call. Marking verified fixed (and thanks for making that change).