Email credentials are not editable

VERIFIED FIXED

Status

Firefox OS
Gaia::E-Mail
P3
normal
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: mushi, Assigned: steveck)

Tracking

({b2g-testdriver, unagi})

unspecified
x86
Mac OS X
b2g-testdriver, unagi

Firefox Tracking Flags

(blocking-basecamp:+)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Steps to reproduce:

1. Open email app
2. Tap top menu button in top left corner
3. Tap settings button
4. Tap an account
4. Tap "credentials"

Expected:
The username and password fields are editable so they can be updated if needed.

Observed:
The fields are not editable.
blocking-basecamp: ? → +
Priority: -- → P3
Component: Gaia → Gaia::E-Mail
(Assignee)

Updated

5 years ago
Assignee: nobody → schung
(Assignee)

Comment 1

5 years ago
Hi Andrew,
In AccountCredentialsCard, we already has onClickSave function to use.
But it is never been used and it only save the password if changed.


Is there limitation for the account.modifyAccount API?
I've tried to change username and it seems work.
But it only changes in CredentialsCard view, username displayed in other view still the same as previous username.
And changing the username seems not a common use scenario.
Should I enable both username and password input or just password?

BTW, If we allow user to change account username/password,
do we need any error handling for account changes?
For example, if we save the wrong username/password, should we popup any dialog for invalid username/password?
Thanks.
Steve, the back-end implementation for modifyAccount is here:
https://github.com/mozilla-b2g/gaia-email-libs-and-more/blob/master/data/lib/mailapi/mailbridge.js#L190

'name' is what we use to visually name the account; it's what is not getting updated.

In any event, we only want to let the user edit their password.  If they need to change their username, they can delete the account and re-create it with the correct username and we will properly validate the account.

The 'setup-fix-password' card is automatically displayed if there is an authentication problem, so no new work is required there.  The 'setup-account-credentials' card already calls clearProblems after calling modifyAccount which will trigger a call to checkAccount on the back-end which will try logging in and should validate the credentials.
(Assignee)

Comment 3

5 years ago
Created attachment 679996 [details]
Patch for making email credentials become editable
Attachment #679996 - Flags: review?(bugmail)
(Assignee)

Comment 4

5 years ago
Hi Rudy,
In this patch, I've made email password editable.
But the input with password type seems have some issue that I could not get/set password correctly via input.value and the the input.value does not sync with UI display result.

Could you please give some comment about this issue? It works fine on FF nightly.
Thanks.
Comment on attachment 679996 [details]
Patch for making email credentials become editable

comments made on pull request, please re-flag review when revisions made
Attachment #679996 - Flags: review?(bugmail)
(Assignee)

Updated

5 years ago
Attachment #679996 - Flags: review?(bugmail)
Attachment #679996 - Flags: review?(bugmail) → review+
merged to gaia/master:
https://github.com/mozilla-b2g/gaia/commit/adbfdd209ff2f9f7aceb36980d04dd35827cca34
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Status: RESOLVED → VERIFIED

Comment 7

5 years ago
Unagi Build ID:20130103070201 - no repro, fix verified - User is able to edit the password, but not the username
You need to log in before you can comment on or make changes to this bug.