808228 - Fix contents and visual polish for bluetooth pairing PIN screen

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Settings, defect, P3)

Description

[Larissa Co [:lco]]

This screen is pretty confusing because it contains too much extraneous text. Remove the text that says "Confirm devices to pair" and the device name. The only thing this screen should contain is the text "To pair with <device> ..."

Also, the text box for entering the PIN seems unpolished because it's left-aligned and doesn't take up the full width. Either center-align the box, or extend it, so that it fills up the width. I may be wrong, but it also looks a little small (or maybe it's the shadow?) Patryk, can you add your comments about it?

Comment 1

[Evelyn Hung]

Larissa, 
I've center-aligned the input box and made it bigger.
Regards to pairing screens, you may notice that all pairing methods(PIN confirm, PIN input) share the same style, this is slightly different to your spec.() 
So do you mean that we don't need title 'Confirm devices to pair' and device name on all these screens?

Comment 2

[Larissa Co [:lco]]

Attachment: Pairing PIN request screen

Comment 3

[Larissa Co [:lco]]

(In reply to Evelyn Hung [:evelyn] from comment #1)
> Larissa, 
> I've center-aligned the input box and made it bigger.

Thanks! I'll review it when I see it on the device.

> Regards to pairing screens, you may notice that all pairing methods(PIN
> confirm, PIN input) share the same style, this is slightly different to your
> spec.() 

Yeah, it's actually different from all of the other alert messages we have. I've created a bug for that. 

> So do you mean that we don't need title 'Confirm devices to pair' and device
> name on all these screens?

Sorry for being confusing. I though I had attached a screenshot for this bug when I wrote it...

My comment was only intended for this use case, where the user needs to enter a PIN. For the other use case, where the user only needs to confirm that the PIN matches, I do want to include the title and the device name (but not the text that's below the device name-- actually don't know what that is, but we don't need to display it),

Comment 4

[David Scravaglieri [:scravag]]

Polish

Comment 5

[Daniel Holbert [:dholbert]]

Currently (on dogfood beta channel) the pairing screen looks like this:
 http://imgur.com/HMvXR

It just says the name of the other device and the PIN, and has [Cancel][Pair] buttons. (and literally no other text at all)

Is that intended?

Comment 6

[Daniel Holbert [:dholbert]]

(After chatting w/ Larissa on IRC, I filed bug 828553 on comment 5)

Comment 7

[Evelyn Hung]

I believe what Larissa said in comment 3 had been fixed by other bugs. Close this bug as invalid.