808233 - Use the proper error text for Bluetooth pairing failures

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Larissa Co [:lco]]

Attachment: Pairing failure screen

See the screenshot for the current message that shows up when the pairing request times out (i.e. neither device responds). This message is inaccurate because neither device had to enter a PIN, and it's not an incorrect PIN that's caused the pairing failure.

The actual message should say "Check that both devices have the same PIN displayed and have accepted the pairing request."

Also see pg. 46 of http://people.mozilla.com/~lco/Settings_B2G/Release_1_Specs/R1_Connectivity_v11.pdf for all the possible error messages that show up.

Comment 1

[Neeraj]

I have resolved this bus.Please assign it to me.

Comment 2

[Neeraj]

Attachment: Proposed patch for this bug.

Hello Vivien,

Here is the pull request(https://github.com/mozilla-b2g/gaia/pull/9983) for the patch.

Please review it.

Regards,

Comment 3

[Evelyn Hung]

Comment on attachment 753727 [details] [diff] [review]
Proposed patch for this bug.

Don't forget to set a reviewer. You can check the history of the code to know who might be able to review your patch.

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 753727 [details] [diff] [review]
Proposed patch for this bug.

Neeraj, thank you for the patch.

Sorry for the delay. Since the bug and the spec is a little bit out of dated, I am not able to review the patch for now. We have the following error messages:

Page Timeout
Connection Timeout
Authentication Timeout
Repeated Attempts
Authentication Rejected
Authentication Canceled
Authentication Failed

The current UX spec we have does not reflect these messages very well. We would need UX designers considering all of the error cases and come up with new messages. The whole process may take longer than expected. We will track it on this bug. It is still welcome that you provide the patch after the messages are finalized.

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Neo, could you help provide new messages based on the given errors? We can have a discussion with the BT team for clarifying the scenario of the errors.

Comment 6

[Neo Hsieh [:neo]]

Hi Carrie,
Please help to follow up this issue. 
Thanks

Comment 7

[Carrie Wang [New account: [e-mail]]]

(In reply to Arthur Chen [:arthurcc] from comment #5)
> Neo, could you help provide new messages based on the given errors? We can
> have a discussion with the BT team for clarifying the scenario of the errors.

Hi Arthur,

I'm now in charge with BT issues. When can we have a short discussion with BT team for the scenario? Thanks!

Comment 8

[Carrie Wang [New account: [e-mail]]]

Dear all, 

My suggestion:

Page timeout/ Connection timeout
(In these cases, the BT is inactivated due to the distance or being switched off.)
---->
Unable to pair devices
-Please check that the device you're trying to pair with is in the effective
 range and has turned on its Bluetooth.


Authentication failed/ Authentication rejected/ Repeated Attempts/ Authentication Canceled/ Authentication Timeout
(In these cases, the request might be canceled or rejected or the displayed PIN might not the same or the input PIN is incorrect.)
---->
Unable to pair devices
-Please check that both devices have accepted the pairing request with a correct PIN code.

Thanks!

(In reply to Arthur Chen [:arthurcc] from comment #4)
> Comment on attachment 753727 [details] [diff] [review]
> Proposed patch for this bug.
> 
> Neeraj, thank you for the patch.
> 
> Sorry for the delay. Since the bug and the spec is a little bit out of
> dated, I am not able to review the patch for now. We have the following
> error messages:
> 
> Page Timeout
> Connection Timeout
> Authentication Timeout
> Repeated Attempts
> Authentication Rejected
> Authentication Canceled
> Authentication Failed
> 
> The current UX spec we have does not reflect these messages very well. We
> would need UX designers considering all of the error cases and come up with
> new messages. The whole process may take longer than expected. We will track
> it on this bug. It is still welcome that you provide the patch after the
> messages are finalized.

Comment 9

[Carrie Wang [New account: [e-mail]]]

Hi Matej,

Please have a look of the strings. Thanks! :)

(In reply to cawang from comment #8)
> Dear all, 
> 
> My suggestion:
> 
> Page timeout/ Connection timeout
> (In these cases, the BT is inactivated due to the distance or being switched
> off.)
> ---->
> Unable to pair devices
> -Please check that the device you're trying to pair with is in the effective
>  range and has turned on its Bluetooth.
> 
> 
> Authentication failed/ Authentication rejected/ Repeated Attempts/
> Authentication Canceled/ Authentication Timeout
> (In these cases, the request might be canceled or rejected or the displayed
> PIN might not the same or the input PIN is incorrect.)
> ---->
> Unable to pair devices
> -Please check that both devices have accepted the pairing request with a
> correct PIN code.
> 
> Thanks!
> 
> (In reply to Arthur Chen [:arthurcc] from comment #4)
> > Comment on attachment 753727 [details] [diff] [review]
> > Proposed patch for this bug.
> > 
> > Neeraj, thank you for the patch.
> > 
> > Sorry for the delay. Since the bug and the spec is a little bit out of
> > dated, I am not able to review the patch for now. We have the following
> > error messages:
> > 
> > Page Timeout
> > Connection Timeout
> > Authentication Timeout
> > Repeated Attempts
> > Authentication Rejected
> > Authentication Canceled
> > Authentication Failed
> > 
> > The current UX spec we have does not reflect these messages very well. We
> > would need UX designers considering all of the error cases and come up with
> > new messages. The whole process may take longer than expected. We will track
> > it on this bug. It is still welcome that you provide the patch after the
> > messages are finalized.

Comment 10

[Matej Novak [:matej]]

Looks good. Just a few small changes to the first one:

Unable to pair devices
Please check that the device you're trying to pair with is within range and has its Bluetooth turned on.

Comment 11

[Evelyn Hung]

I'd like to be a mentor of this bug.

Comment 12

[Antonio Ladeia]

Hello,

I reproduce here some of these states and could help repair them.

It would be a great opportunity to start contributing.

Evelyn can you mentor me?

Comment 13

[Evelyn Hung]

Sure. I think we can start on asking UX's opinion to get updated information (and strings).

Omega, it's a pretty old bug, so could you please confirm that the strings above is up to date and we still want to make these change?

Comment 14

[Omega Feng [:Omega] [:馮於懋]]

ni? new UX owner Jenny. :)

Comment 15

[Jenny Lee]

Hello Evelyn, please see below for updated error message (slight modification), tks!

Page timeout/ Connection timeout
-----------
Unable to pair
-Couldn't pair with [device name]. Please check that the device you're trying to pair with is within range and has its Bluetooth turned on.


Authentication failed/ Authentication rejected/ Repeated Attempts/ Authentication Canceled/ Authentication Timeout
-----------
Unable to pair 
-Couldn't pair with [device name]. Please check that both devices have accepted the pairing request with a correct PIN code.

Comment 16

[Antonio Ladeia]

ehung, 

I talk to Evelyn because I'm interested in fixing this bug.

can you help me with it?

Comment 17

[Evelyn Hung]

Hi Antonio, I think it's a few string changes. Could you start from finding out when the error message will be displayed in the code? :)

Comment 18

[Antonio Ladeia]

Yes evelyn.

I make this!

Comment 19

[Antonio Ladeia]

Comment on attachment 753727 [details] [diff] [review]
Proposed patch for this bug.

This commit is incomplete. This bug dont put the "device name" and dont put the Authentication failed string.

Comment 20

[Antonio Ladeia]

Hello Evelyn

I need insert 'if else's in codes of handling of 'error message' for each key (Authentication failed/ Authentication rejected/ Repeated Attempts/ Authentication Canceled/ Authentication Timeout)?

Comment 21

[Evelyn Hung]

Comment on attachment 753727 [details] [diff] [review]
Proposed patch for this bug.

Hi Antonio, thanks for the patch, it's a good start!

Just a few suggestions:
1. we usually copy strings from what UX said, so it's better if you just exactly copy the words in comment 15.

2. in comment 15, there is a [device name] replacement, you should use a variable in the strings and pass correct name in code. Here is a good example, you can trace the code and see how the {{length}} be replaced.

  https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/locales/settings.en-US.properties#L398

3. As you have noticed, to better handling Authentication error cases, you need to add a check in code for checking error name, so you can properly display the error message.

Sorry for my late review, and feel free to need info me on the bug if you have any question. :)

Comment 22

[[e-mail]]

BT paring wording has been updated with current UI spec