LocalStorage Telemetry to determine the fraction of dirty keys during a flush

RESOLVED FIXED in mozilla19

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: vladan, Assigned: vladan)

Tracking

16 Branch
mozilla19
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 677980 [details] [diff] [review]
Report % of dirty keys in a scope during a flush

I would like to know what proprotion of a scope's keys is dirty when scope data gets flushed to disk. If we find that we typically flush the majority of a scope's keys to disk with each flush, we may want to switch to a simpler backend for LocalStorage, e.g. one flat file per LocalStorage scope
Attachment #677980 - Flags: review?(taras.mozilla)

Comment 1

6 years ago
Comment on attachment 677980 [details] [diff] [review]
Report % of dirty keys in a scope during a flush

12 buckets seems kinda weird, but works for me
Attachment #677980 - Flags: review?(taras.mozilla) → review+
(Assignee)

Comment 2

6 years ago
(In reply to Taras Glek (:taras) from comment #1)
> 12 buckets seems kinda weird, but works for me

It's because there are always buckets for 0%, 1% and the max value. So we get 12 buckets: "0%", "1%", "10%, 20% ... 90%", "100%"
(Assignee)

Comment 3

6 years ago
Comment on attachment 677980 [details] [diff] [review]
Report % of dirty keys in a scope during a flush

https://hg.mozilla.org/integration/mozilla-inbound/rev/dfe6972056d6
Attachment #677980 - Flags: checkin+

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/dfe6972056d6
Assignee: nobody → vdjeric
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.