Closed Bug 808278 Opened 9 years ago Closed 9 years ago

Unable to Build with VS2008SP1/VC9 since Bug 740015 (Update Yarr to WebKit rev 130234).

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: philip.chee, Assigned: philip.chee)

References

Details

(Keywords: perf)

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #740015 +++

VS2008SP1 (VC9)
I'm getting lots of "Cannot open include file: 'stdint.h': No such file or directory"

c:\t1\hg\comm-central\mozilla\js\src\yarr\CheckedArithmetic.h(34) : fatal error C1083: Cannot open include file: 'stdint.h': No such file or directory
> // DO NOT EDIT! - this file autogenerated by YarrCanonicalizeUCS2.js
This worried me a bit but I edited the file anyway since I don't see where YarrCanonicalizeUCS2.js is invoked to generate YarrCanonicalizeUCS2.cpp
Attachment #677990 - Flags: feedback?(dmandelin)
Attachment #677990 - Flags: feedback?(bill)
Comment on attachment 677990 [details] [diff] [review]
Patch v1.0 Proposed fix.

This looks correct to me.  I can also verify that it fixes the build issue under VC9 for me, plus it does not cause any issues for my Linux builds.Linux
Attachment #677990 - Flags: feedback?(bill) → feedback+
Comment on attachment 677990 [details] [diff] [review]
Patch v1.0 Proposed fix.

Review of attachment 677990 [details] [diff] [review]:
-----------------------------------------------------------------

This is fine. One of the things we try to do with the Yarr imported code is to keep our local changes minimal. Tweaking header files is exactly the kind of minimal change we seem to be forced to do.
Attachment #677990 - Flags: feedback?(dmandelin) → feedback+
Comment on attachment 677990 [details] [diff] [review]
Patch v1.0 Proposed fix.

> This is fine. One of the things we try to do with the Yarr imported code is to
> keep our local changes minimal. Tweaking header files is exactly the kind of
> minimal change we seem to be forced to do
Thanks! Now asking for review since this seems to be the preferred approach.
Attachment #677990 - Flags: review?(dmandelin)
Attachment #677990 - Flags: review?(dmandelin) → review+
Thanks. I don't have a Mozilla inbound tree handy so setting the checkin-needed keyword.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/11ff92705a23
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Assignee: general → philip.chee
You need to log in before you can comment on or make changes to this bug.