Closed
Bug 808319
Opened 13 years ago
Closed 12 years ago
Fix some GCC warnings in nsGStreamerReader.cpp
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: romaxa, Assigned: alessandro.d)
Details
Attachments
(1 file, 1 obsolete file)
|
2.69 KB,
patch
|
alessandro.d
:
review+
|
Details | Diff | Splinter Review |
Some gcc warnings could be easily fixed
|
Reporter | |
Comment 1•13 years ago
|
||
Comment on attachment 678045 [details] [diff] [review]
Fix 2 warnings in gstreamer reader
Also I'm worry about nsGStreamerReader::NeedData which tries to compare uint aLength with -1
Attachment #678045 -
Flags: review?(alessandro.d)
|
||
Comment 2•13 years ago
|
||
(In reply to Oleg Romashin (:romaxa) from comment #1)
> Also I'm worry about nsGStreamerReader::NeedData which tries to compare uint
> aLength with -1
It does look odd, but it seems to be valid, based on http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gst-plugins-base-libs/html/gst-plugins-base-libs-appsrc.html#GstAppSrcCallbacks
|
Assignee | |
Comment 3•12 years ago
|
||
Rebased to apply on today's HEAD.
Does this need to be reviewed further or can it go in now?
Attachment #678045 -
Attachment is obsolete: true
Attachment #678045 -
Flags: review?(alessandro.d)
Attachment #720553 -
Flags: review+
|
|
Reporter | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 4•12 years ago
|
||
Keywords: checkin-needed
|
||
Comment 5•12 years ago
|
||
Assignee: nobody → alessandro.d
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in
before you can comment on or make changes to this bug.
Description
•