The default bug view has changed. See this FAQ.

Port |Bug 797745 - Move l10n-merge/relativesrcdir logic from config.mk into JarMaker.py, allow jar.mn to override| to comm-central

RESOLVED FIXED in Thunderbird 19.0

Status

MailNews Core
Build Config
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Ian Neal, Assigned: Ian Neal)

Tracking

Trunk
Thunderbird 19.0
Dependency tree / graph

SeaMonkey Tracking Flags

(seamonkey2.16 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Now that the following patches have landed on mozilla-central:
* Bug 797745 - Move l10n-merge/relativesrcdir logic from config.mk into JarMaker.py, allow jar.mn to override
* Bug 808289 - Win32/Linux Nightly localised builds use en-US strings for interface

The relevant bits need to be ported to comm-central
(Assignee)

Comment 1

4 years ago
Created attachment 678063 [details] [diff] [review]
Port some patches [Checked in: Comment 7]

This also ports:
* Bug 748130 - Replace FORCE dependencies, repacks are a conditional force

Pushed to try-comm-central
Assignee: nobody → iann_bugzilla
Status: NEW → ASSIGNED

Comment 2

4 years ago
Try run for 958506b2bfb4 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=958506b2bfb4
Results (out of 37 total builds):
    success: 24
    warnings: 10
    failure: 3
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/iann_cvs@blueyonder.co.uk-958506b2bfb4
(Assignee)

Comment 3

4 years ago
Comment on attachment 678063 [details] [diff] [review]
Port some patches [Checked in: Comment 7]

The two failures on leak test builds for Linux/Linux-x64 are logged in bug 808379 and are not to do with this patch.
Attachment #678063 - Flags: review?(mbanner)
(Assignee)

Updated

4 years ago
Attachment #678063 - Flags: review?(bugspam.Callek)
BTW: Did someone test if Bug 808289 actually affects SeaMonkey and/or Thunderbird? I downloaded a SeaMonkey l10n nightly from ftp://ftp.mozilla.org/pub/mozilla.org/seamonkey/nightly/latest-comm-central-trunk-l10n/seamonkey-2.16a1.de.linux-i686.tar.bz2 and it looked fine (German UI).
Ah, wait, maybe the mozilla-central fix fixed it for comm-central, too. Not sure..
Comment on attachment 678063 [details] [diff] [review]
Port some patches [Checked in: Comment 7]

Review of attachment 678063 [details] [diff] [review]:
-----------------------------------------------------------------

I will r+ based on code inspection this does look good.

I will caution you to please land this independant (on a day-wise) of the other build config changes you are doing, and to make sure you monitor l10n nightlies (and dep builds) both for a complete locale (like en-GB) a close to complete locale (like German) and an out-of-date locale (like Turkish). L10n breaks in weird ways, so I want you to verify that it works before this lands and after, otherwise we risk breaking it more.

Please verify both TB and SeaMonkey :-)
Attachment #678063 - Flags: review?(mbanner)
Attachment #678063 - Flags: review?(bugspam.Callek)
Attachment #678063 - Flags: review+
(Assignee)

Comment 7

4 years ago
Comment on attachment 678063 [details] [diff] [review]
Port some patches [Checked in: Comment 7]

http://hg.mozilla.org/comm-central/rev/84289543844f
Attachment #678063 - Attachment description: Port some patches → Port some patches [Checked in: Comment 7]
(Assignee)

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-seamonkey2.16: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 19.0
You need to log in before you can comment on or make changes to this bug.