Closed Bug 808346 Opened 8 years ago Closed 8 years ago

Don't scan sys.path to discover mach modules

Categories

(Firefox Build System :: Mach Core, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla19

People

(Reporter: gps, Unassigned)

References

Details

Attachments

(1 file)

Scanning sys.path for mach modules is neat and all. But, we agreed when it was implemented that it isn't ideal. Since then (bug 794509), we've established the convention of creating mach_commands.py files around the tree and referencing them explicitly in the main mach driver (./mach). This way, the mach driver has complete control over what gets loaded. I think this is more practical than having automagical side-effects.

The attached patch removes sys.path scanning. But, it does preserve the ability to scan directories. The mach commands in python/mozbuild have been moved to a mach_commands.py file.
Attachment #678076 - Flags: review?(jhammel)
Blocks: 807974
Comment on attachment 678076 [details] [diff] [review]
Remove sys.path scanning, v1

lgtm
Attachment #678076 - Flags: review?(jhammel) → review+
https://hg.mozilla.org/mozilla-central/rev/f561a4ffeeb9
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.