808363 - Rectify preproduction master local mods

Status: RESOLVED WONTFIX

(Release Engineering :: General, defect, P4)

Description

[Justin Wood (:Callek)]

So when looking to possibly add some sut_tools testing to preproduction, I noticed that we have some local mods to our preprod instance relating to testing of signing.

We no longer have tools/release/signing/tests.py but we do have tools/release/signing/testsigning.sh, Ben should we take the change in preprod right now to the actual repo, or should we start testing with testsigning.sh ?

[cltbld@preproduction-master ~]$ hg -R /builds/buildbot/preproduction diff
diff --git a/master/preproduction_factory.py b/master/preproduction_factory.py
--- a/master/preproduction_factory.py
+++ b/master/preproduction_factory.py
@@ -151,21 +151,16 @@ class PPBuildFactory(BuildFactory):
             workdir="tools",
             flunkOnFailure=False,
             name='tools_scripts_pylint',
             project='tools_scripts',
         ))

     def tools_run_tests(self):
         self.addStep(ShellCommand(
-            workdir='tools/release/signing',
-            command=['python', 'tests.py'],
-            name='release_signing_tests',
-        ))
-        self.addStep(ShellCommand(
             workdir='tools/lib/python',
             name='tools_lib_nosetests',
             env={'PYTHONPATH': '.:vendor'},
             command=['nosetests'],
         ))
         self.addStep(ShellCommand(
             workdir='tools/clobberer',
             name='clobbberer_test',

Comment 1

[[e-mail] (:bhearsum)]

I have no idea about this. Catlee might've changed something when he wrote the signing server tests?

Comment 2

[Chris AtLee [:catlee]]

I don't remember doing that...What's the mtime on that file?

Comment 3

[Justin Wood (:Callek)]

Its now newer than it was when I filed this bug, since I added the validation for mobile devices.json file.

So what is our next step here, morph this to be setting up signing tests in preprod and making the repo match reality?

Comment 4

[Chris AtLee [:catlee]]

Let's remove it from our repo then.

Comment 5

[[e-mail] (:bhearsum)]

preprod is dead!