808412 - Add "Open Calendar File…" to Calendar list context menu.

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Richard Marti (:Paenglab)]

Follow-up of bug 785480 to add the missing menu item.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: patch

Like in bug 785480 comment 9 proposed, I've added the menu item on calendar list context menu.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: patch for aurora/beta

The same patch for Aurora/Beta without localization. I've added the label/accesskey entities directly to the XUL file. If the translation still would happen, then this would be taken.

Comment 3

[Stefan Sitter [:ssitter]]

> The same patch for Aurora/Beta without localization. I've added the
> label/accesskey entities directly to the XUL file. If the translation still
> would happen, then this would be taken.

Why not reuse the existing, already translated menu string instead of hard coding the English string into the xul file?

Comment 4

[Richard Marti (:Paenglab)]

(In reply to Stefan Sitter from comment #3)
> > The same patch for Aurora/Beta without localization. I've added the
> > label/accesskey entities directly to the XUL file. If the translation still
> > would happen, then this would be taken.
> 
> Why not reuse the existing, already translated menu string instead of hard
> coding the English string into the xul file?

Because the string is only "Calendar File…" without "Open". I don't know if it would work when I make a patchwork of the two strings "Open" and "Calendar File…". I can try this this evening.

Comment 5

[Stefan Sitter [:ssitter]]

Ah, OK. I see now that "Open Calendar File…" is only defined in sunbird/menuOverlay.dtd but not in Lightning.

Comment 6

[Richard Marti (:Paenglab)]

I checked how the joined label would look in German: Öffnen Kalenderdatei…
This isn't good German so I think it's better leave it English than this weird German or other langage (maybe they also need to change the order).

Comment 7

[Matthew Mecca [:mmecca]]

We could also just use Open -> Calendar File as a sub-menu for aurora and beta. It would be inconsistent with the "Open Saved Message" menu item, but better than an untranslated string IMO.

Comment 8

[Philipp Kewisch [:Fallen][📱📆]]

(In reply to Matthew Mecca [:mmecca] from comment #7)
> We could also just use Open -> Calendar File as a sub-menu for aurora and
> beta. It would be inconsistent with the "Open Saved Message" menu item, but
> better than an untranslated string IMO.

Yeah, I agree. Maybe modify the DOM like this:

Open >
        Calendar File
        Open Saved Message

Comment 9

[Richard Marti (:Paenglab)]

Attachment: patch for all branches

Now on AppMenu/File with the new submenu "Open" like on main menu.

Do we want this also for trunk? Then we have not only this menu for two versions.

Comment 10

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 679206 [details] [diff] [review]
patch for all branches

Review of attachment 679206 [details] [diff] [review]:
-----------------------------------------------------------------

I'm fine with taking this for all branches, r=philipp

::: calendar/lightning/content/lightning-menus.xul
@@ +452,5 @@
>                 observes="calendar_new_calendar_command"
>                 insertafter="appmenu_newAccountMenuItem"/>
>    </menupopup>
> +  
> +  <menupopup id="appmenu_FilePopup">

Extra whitespace

@@ +470,5 @@
> +                  oncommand="openLocalCalendar();"/>
> +      </menupopup>
> +    </menu>
> +  </menupopup>
> +  <menuitem id="appmenu_openMessageFileMenuitem" hidden="true"/>  

Extra whitespace

Comment 11

[Richard Marti (:Paenglab)]

Pushed to comm-central: http://hg.mozilla.org/comm-central/rev/367153353ca4
comm-aurora: http://hg.mozilla.org/releases/comm-aurora/rev/e75dafc4b3b0
and comm-beta: http://hg.mozilla.org/releases/comm-beta/rev/556615e5c8e7