Closed Bug 808412 Opened 8 years ago Closed 8 years ago

Add "Open Calendar File…" to Calendar list context menu.

Categories

(Calendar :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(1 file, 2 obsolete files)

Follow-up of bug 785480 to add the missing menu item.
Attached patch patch (obsolete) — Splinter Review
Like in bug 785480 comment 9 proposed, I've added the menu item on calendar list context menu.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #678136 - Flags: review?(philipp)
Attached patch patch for aurora/beta (obsolete) — Splinter Review
The same patch for Aurora/Beta without localization. I've added the label/accesskey entities directly to the XUL file. If the translation still would happen, then this would be taken.
Attachment #678136 - Attachment is obsolete: true
Attachment #678136 - Flags: review?(philipp)
Attachment #678137 - Flags: review?(philipp)
Attachment #678137 - Flags: approval-calendar-beta?
Attachment #678137 - Flags: approval-calendar-aurora?
Attachment #678136 - Attachment is obsolete: false
Attachment #678136 - Flags: review?(philipp)
> The same patch for Aurora/Beta without localization. I've added the
> label/accesskey entities directly to the XUL file. If the translation still
> would happen, then this would be taken.

Why not reuse the existing, already translated menu string instead of hard coding the English string into the xul file?
(In reply to Stefan Sitter from comment #3)
> > The same patch for Aurora/Beta without localization. I've added the
> > label/accesskey entities directly to the XUL file. If the translation still
> > would happen, then this would be taken.
> 
> Why not reuse the existing, already translated menu string instead of hard
> coding the English string into the xul file?

Because the string is only "Calendar File…" without "Open". I don't know if it would work when I make a patchwork of the two strings "Open" and "Calendar File…". I can try this this evening.
Ah, OK. I see now that "Open Calendar File…" is only defined in sunbird/menuOverlay.dtd but not in Lightning.
I checked how the joined label would look in German: Öffnen Kalenderdatei…
This isn't good German so I think it's better leave it English than this weird German or other langage (maybe they also need to change the order).
We could also just use Open -> Calendar File as a sub-menu for aurora and beta. It would be inconsistent with the "Open Saved Message" menu item, but better than an untranslated string IMO.
(In reply to Matthew Mecca [:mmecca] from comment #7)
> We could also just use Open -> Calendar File as a sub-menu for aurora and
> beta. It would be inconsistent with the "Open Saved Message" menu item, but
> better than an untranslated string IMO.

Yeah, I agree. Maybe modify the DOM like this:

Open >
        Calendar File
        Open Saved Message
Now on AppMenu/File with the new submenu "Open" like on main menu.

Do we want this also for trunk? Then we have not only this menu for two versions.
Attachment #678137 - Attachment is obsolete: true
Attachment #678137 - Flags: review?(philipp)
Attachment #678137 - Flags: approval-calendar-beta?
Attachment #678137 - Flags: approval-calendar-aurora?
Attachment #679206 - Flags: review?(philipp)
Comment on attachment 679206 [details] [diff] [review]
patch for all branches

Review of attachment 679206 [details] [diff] [review]:
-----------------------------------------------------------------

I'm fine with taking this for all branches, r=philipp

::: calendar/lightning/content/lightning-menus.xul
@@ +452,5 @@
>                 observes="calendar_new_calendar_command"
>                 insertafter="appmenu_newAccountMenuItem"/>
>    </menupopup>
> +  
> +  <menupopup id="appmenu_FilePopup">

Extra whitespace

@@ +470,5 @@
> +                  oncommand="openLocalCalendar();"/>
> +      </menupopup>
> +    </menu>
> +  </menupopup>
> +  <menuitem id="appmenu_openMessageFileMenuitem" hidden="true"/>  

Extra whitespace
Attachment #679206 - Flags: review?(philipp)
Attachment #679206 - Flags: review+
Attachment #679206 - Flags: approval-calendar-beta+
Attachment #679206 - Flags: approval-calendar-aurora+
Attachment #678136 - Attachment is obsolete: true
Attachment #678136 - Flags: review?(philipp)
Attachment #679206 - Attachment description: patch for aurora/beta → patch for all branches
Pushed to comm-central: http://hg.mozilla.org/comm-central/rev/367153353ca4
comm-aurora: http://hg.mozilla.org/releases/comm-aurora/rev/e75dafc4b3b0
and comm-beta: http://hg.mozilla.org/releases/comm-beta/rev/556615e5c8e7
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.9
You need to log in before you can comment on or make changes to this bug.