808523 - [UX] Dialer's add contact button icon missing

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P2)

Description

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Add contact button screenshot

Hi guys, I was including the code to activate and deactivate the "Add contact" button in the Dialer (see attached file, the one in the upper left corner) but it turns out that it is missing or not done yet. Is it? I would need this icon and guidelines for the normal/activated and disabled states (in case some opacity is applied in the second case).

Thank you very much.

Comment 1

[Victoria Gerchinhoren [:vicky]]

You can find the new assets here:
https://www.dropbox.com/sh/9zv11zgzw9ogggs/iEvlyaTKw8

The sample screen here:
https://www.dropbox.com/sh/sh2mvuvgo3i0l9e/Ytmzwg5_9T#f:DailerIcons1.psd

And description of the disabled button state in this bug: 
https://bugzilla.mozilla.org/show_bug.cgi?id=816125

If you have any question regarding alignment or anyhitng, please do not hesitate.

Comment 2

[Peter La]

Hi Vicky,

By the way, some of the assets in your link are old (though not directly related to this bug):

-> Backspace/Delete icon is not the new one.

-> Those round icons with the red/green phones inside them are also using a really old phone icon.

I believe I sent you a link to the new stuff recently.

Also, gtorodelvalle, I am going to be committing a change to the dialer iconography, as a lot of it looks outdated or needs work.  Because you're working on the Add Contact icon, I will leave that out of my change, so we don't collide.

Comment 3

[Victoria Gerchinhoren [:vicky]]

Peter,
I didn't erase the old icons, will do it ASAP, but the new icons are OK. As far as I can see the only one missing there is the clear one as I thought no change was made to it. 

Anyways will leave this icons update to you as it's your thing (I have a hard time finding things in the icons folder!).

Comment 4

[Peter La]

FYI.  I checked in a new 'add contact' icon with my fix for Bug 813091.

gtorodelvalle, are you still working on this?

Comment 5

[Germán Toro del Valle (:gtorodelvalle)]

Hi Peter, yeah, definitely this is something in my task queue... ;-) Anyhow, this is the bug I am responsible for: https://bugzilla.mozilla.org/show_bug.cgi?id=813147 related to this issue so if the "Add contact" icon is ready (which I understand it is) I would suggest you to evolve this bug (808523) to RESOLVED-FIXED and I will include the icon and evolve 813147 as soon as it lands in Gaia ;-) Are you fine with this? Thank you very much!

Comment 6

[Peter La]

Hi there, and thanks. :)  As a standard practice for our team, we have not been moving bugs to 'RESOLVED-FIXED' until it has received QA, so unless you object, I am going to leave it as is for now.

Thanks again!

Comment 7

[Germán Toro del Valle (:gtorodelvalle)]

Absolutely! ;-) Thank you very much :-)

Comment 8

[ayman maat :maat]

RFI vicky to look into this

Comment 9

[Victoria Gerchinhoren [:vicky]]

Clarified.

Comment 10

[ayman maat :maat]

request QA to test

Comment 11

[Al Tsai [:atsai]]

dialer seems good now.
Mark as resolve fixed