Closed Bug 808545 Opened 7 years ago Closed 7 years ago

Tweak the exception message for runxpcshelltests.py profile cleanup failures

Categories

(Testing :: XPCShell Harness, defect, minor)

defect
Not set
minor

Tracking

(firefox17 fixed, firefox18 fixed)

RESOLVED FIXED
mozilla19
Tracking Status
firefox17 --- fixed
firefox18 --- fixed

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file)

At the moment we use:
sys.exc_info()[0]
...which gives us:
TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/xpcshell/tests/services/aitc/tests/unit/test_aitc_client.js | Failed to clean up the test profile directory: <type 'exceptions.OSError'>

I think it would be clearer to use:
sys.exc_info()[1]
...which should give us something like:
TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/xpcshell/tests/services/aitc/tests/unit/test_aitc_client.js | Failed to clean up the test profile directory: [Errno 13] Permission denied: '/var/folders/wq/fgxf4g514bn06sl6r8202x6r00000w/T/tmpGDAdQc/Cache'
Attached patch Patch v1Splinter Review
Attachment #678288 - Flags: review?(gps)
Attachment #678288 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/0a6cb7947e07
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.