Tweak the exception message for runxpcshelltests.py profile cleanup failures

RESOLVED FIXED in Firefox 17

Status

Testing
XPCShell Harness
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

Trunk
mozilla19
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox17 fixed, firefox18 fixed)

Details

Attachments

(1 attachment)

At the moment we use:
sys.exc_info()[0]
...which gives us:
TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/xpcshell/tests/services/aitc/tests/unit/test_aitc_client.js | Failed to clean up the test profile directory: <type 'exceptions.OSError'>

I think it would be clearer to use:
sys.exc_info()[1]
...which should give us something like:
TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/xpcshell/tests/services/aitc/tests/unit/test_aitc_client.js | Failed to clean up the test profile directory: [Errno 13] Permission denied: '/var/folders/wq/fgxf4g514bn06sl6r8202x6r00000w/T/tmpGDAdQc/Cache'
(Assignee)

Comment 1

5 years ago
Created attachment 678288 [details] [diff] [review]
Patch v1
Attachment #678288 - Flags: review?(gps)

Updated

5 years ago
Attachment #678288 - Flags: review?(gps) → review+
(Assignee)

Comment 2

5 years ago
Thank you for the review :-)

https://hg.mozilla.org/integration/mozilla-inbound/rev/0a6cb7947e07
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/0a6cb7947e07
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/db70683ea79f
https://hg.mozilla.org/releases/mozilla-beta/rev/1651fc592d90
status-firefox17: --- → fixed
status-firefox18: --- → fixed
You need to log in before you can comment on or make changes to this bug.