808619 - Evme UI improvements

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect, P3)

Description

[Ran Ben Aharon [:ranbena] EverythingMe]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_2) AppleWebKit/537.11 (KHTML, like Gecko) Chrome/23.0.1271.60 Safari/537.11

Steps to reproduce:

1. Geolocation prompt
2. Bookmark icon size and apps shadow
3. Font style
4. Home button function
5. Smartfolder feature
6. Offline apps feature
7. Shortcuts edit mode implementation
8. Over scrolling
9. Header and searchbar style
10. Various bug fixes and performance optimisations



Actual results:

1. Still appears in old version. Not using true geolocation position.
2,3. Not the right styling
4. Takes back to landing page instead of expected functionality
5,6,7.  Not up-to-date
8. Has bounce back
9. Not up-to-date
10. Not implemented


Expected results:

1. Should be the OS getCurrentPosition
2. Should be 49x49 and he correct shadow
3. Should be MozTT etc.
4. Should close smartfolder, return from shortcut edit mode etc. without returning to landing page
5. Should be there
6. Should be there
7. Should be implemented with a <select>
8. Should have no bounce back
9. Should be up-to-date
10. Implemented

Comment 1

[Cristian Rodriguez (:crdlc)]

Please add the patch here and IMHO it's very difficult to review it, there are 46 files changed. Vivien any suggestion? Thanks

Comment 2

[Jose Manuel Cantera]

a link to the PR from here can also help. 

I agree with Cristian that smaller bugs and simple PRs help reviews.

Comment 3

[Ran Ben Aharon [:ranbena] EverythingMe]

https://github.com/mozilla-b2g/gaia/pull/6167

Comment 4

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: UI fixes and changes

Comment 5

[Ran Ben Aharon [:ranbena] EverythingMe]

Perhaps I can help the reviewer. Apart for minor changes in apps/homescreen/index.html, it's all Evme files with zero affect on the rest of the system.

Comment 6

[Cristian Rodriguez (:crdlc)]

I don't have problems to review although I prefer less code. Vivien will decide if there are or not risk with this code on the rest  of the system. IMHO there aren't risk but I am only a reviewer here :) Tomorrow I can start on reviewing friend

Comment 7

[Ran Ben Aharon [:ranbena] EverythingMe]

Cool. I'll get some comments into the pull request as well to make it easier to understand.

Comment 8

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: UI fixes and changes

Comment 9

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: Code changes due to PR comments

Comment 10

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: More code changes due to PR comments

Comment 11

[Cristian Rodriguez (:crdlc)]

r+ and blocking-basecamp+ landing

Comment 16

[Deepa Subramanian]

Verified on Unagi device Build ID: 20130112070202
v1.o