Closed
Bug 808647
Opened 12 years ago
Closed 12 years ago
Disable failing sanity tests for B2G reftest
Categories
(Testing :: Reftest, defect)
Testing
Reftest
Tracking
(firefox18 fixed, firefox19 fixed)
RESOLVED
FIXED
mozilla19
People
(Reporter: jgriffin, Assigned: jgriffin)
References
Details
Attachments
(1 file)
1.48 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•12 years ago
|
||
Assignee | ||
Comment 2•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1e3b0555498f
Assignee: nobody → jgriffin
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1e3b0555498f
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Why are these skip-if rather than fails-if?
Comment 5•12 years ago
|
||
(In reply to David Baron [:dbaron] from comment #4) > Why are these skip-if rather than fails-if? Tests run about 10 times slower on the emulator, and there are currently thousands of tests that fail/are random oranges for various reasons (yes there are some problems either with B2G or the automation that needs to be solved). In the meantime I don't want to have thousands of failing/random tests taking up test slave time while these issues are being fixed.
Comment 6•12 years ago
|
||
This patch is only 5 tests, but when the full set of passing tests get enabled there will be a lot more skip-if's than 5
I think skip-if was really a misnomer; I should perhaps have called it crashes-or-hangs-if. Marking tests as skipped means they're probably never going to be revisited, even if what's causing them to fail gets fixed.
Assignee | ||
Comment 8•12 years ago
|
||
Pushed to aurora so we can turn reftests on there: https://hg.mozilla.org/releases/mozilla-aurora/rev/df349536978c
status-firefox18:
--- → fixed
status-firefox19:
--- → fixed
Comment 9•12 years ago
|
||
(In reply to David Baron [:dbaron] from comment #7) > I think skip-if was really a misnomer; I should perhaps have called it > crashes-or-hangs-if. Marking tests as skipped means they're probably never > going to be revisited, even if what's causing them to fail gets fixed. I don't know whether the tests I've triaged are random oranges or perma oranges. So I can only mark tests as skip-if or random-if. I filed bug 773482 awhile ago (the tests that got disabled in this patch are covered in some of 773482's dependencies). I will be working to re-enable the tests that get skipped in the initial triage. When it gets to the point where we have a more manageable set of failing tests I'll get a patch to re-enable everything and use a project branch to re-triage the failures properly.
You need to log in
before you can comment on or make changes to this bug.
Description
•