808746 - Code to avoid using single paint buffer for tiling is wrong

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Benoit Girard (:BenWa)]

Attachment: patch

We use a single paint buffer if we're going to be painting several tiles at once which is faster. However if we're only painting a single tile we shouldn't use the single paint buffer since we're just forcing a useless copy.

Comment 1

[Benoit Girard (:BenWa)]

Comment on attachment 678445 [details] [diff] [review]
patch

https://hg.mozilla.org/integration/mozilla-inbound/rev/0d4e09ade336

Comment 2

[Phil Ringnalda (:philor)]

Backed out in http://hg.mozilla.org/integration/mozilla-inbound/rev/8f5204fb76c8 - https://tbpl.mozilla.org/php/getParsedLog.php?id=16777500&tree=Mozilla-Inbound, https://tbpl.mozilla.org/php/getParsedLog.php?id=16777320&tree=Mozilla-Inbound

Comment 3

[Benoit Girard (:BenWa)]

The failure from the first log may just need us to increase fuzzing. The second set of failures are more serious and will need attention.

Comment 4

[Benoit Girard (:BenWa)]

Filed bug 809489 for the first failure. It's not caused by this patch.

Comment 5

[Benoit Girard (:BenWa)]

Filed bug 809493 for 'layout/reftests/scrolling/opacity-mixed-scrolling-2.html' failure. This the problems in the that page aren't caused by this patch but it triggers the reference failure.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

This code doesn't exist any more.