808750 - More logging and safety in resource callbacks

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Richard Newman [:rnewman]]

We're seeing some odd failures, so time for more catches and logs.

Comment 1

[Richard Newman [:rnewman]]

Attachment: Ridiculously paranoid. v1

This makes every channel callback in Resource ridiculously paranoid about throwing. See blocked bug for why.

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 678524 [details] [diff] [review]
Ridiculously paranoid. v1

Review of attachment 678524 [details] [diff] [review]:
-----------------------------------------------------------------

Necessary evil.

::: services/sync/modules/resource.js
@@ +513,5 @@
> +    try {
> +      siStream = Cc["@mozilla.org/scriptableinputstream;1"].createInstance(Ci.nsIScriptableInputStream);
> +      siStream.init(stream);
> +    } catch (ex) {
> +      this._log.warn("Exception creating nsIScriptableInputStream." + Utils.exceptionStr(ex));

CommonUtils

@@ +514,5 @@
> +      siStream = Cc["@mozilla.org/scriptableinputstream;1"].createInstance(Ci.nsIScriptableInputStream);
> +      siStream.init(stream);
> +    } catch (ex) {
> +      this._log.warn("Exception creating nsIScriptableInputStream." + Utils.exceptionStr(ex));
> +      this._log.debug("Parameters: " + req.URI.spec + ", " + stream + ", " + off + ", " + count);

Assuming req.URI is defined. How paranoid do you want to be? ;)

Comment 3

[Richard Newman [:rnewman]]

(In reply to Gregory Szorc [:gps] from comment #2)

> CommonUtils

Damn qref.

> Assuming req.URI is defined. How paranoid do you want to be? ;)

At that point we'll have already logged _something_; an exception in that particular line would be apparent due to its absence. I do check for that in the redirect handler! :D

Comment 4

[Richard Newman [:rnewman]]

Interestingly, I just noticed a bunch of other Utils.*:

      // Got a response, but an exception occurred during processing.
      // This shouldn't occur.
      this._log.warn("Caught unexpected exception " + Utils.exceptionStr(ex) +
                     " in _onComplete.");


Gonna fix those, too.

Comment 5

[Richard Newman [:rnewman]]

https://hg.mozilla.org/services/services-central/rev/7c861ef4f235

… with extensions.

Comment 6

[Richard Newman [:rnewman]]

https://hg.mozilla.org/mozilla-central/rev/7c861ef4f235