808764 - Android xpcshell tests do not set XPCOM_DEBUG_BREAK and some other env vars

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Geoff Brown [:gbrown]]

With environment variable logging corrected (bug 808728), it is apparent that some environment variables set by make xpcshell-tests are not set for make xpcshell-tests-remote. For example:

XPCOM_DEBUG_BREAK, 
NS_TRACE_MALLOC_DISABLE_STACKS
XPCOM_MEM_LEAK_LOG
MOZ_CRASHREPORTER_NO_REPORT

Comment 1

[Geoff Brown [:gbrown]]

It's easy to set these, but doing so worsens bug 752126 - it makes the command line too long for adb.

Comment 2

[Geoff Brown [:gbrown]]

Attachment: Set XPCOM_DEBUG_BREAK, etc env vars

Comment 3

[Geoff Brown [:gbrown]]

Attachment: Set XPCOM_DEBUG_BREAK, etc env vars

Set additional environment variables. With patches for bugs 752126, 808729 and this bug, the wrapper script now looks like this:

#!/system/bin/sh
export XPCOM_DEBUG_BREAK=stack-and-abort
export GRE_HOME=/data/data/org.mozilla.fennec_mozdev
export XPCOM_MEM_LEAK_LOG=/data/local/tests/xpcshell/p/leaks.log
export XPCSHELL_TEST_PROFILE_DIR=/data/local/tests/xpcshell/p
export HOME=/data/local/tests/xpcshell/p
export MOZ_CRASHREPORTER_NO_REPORT=1
export MOZ_LINKER_CACHE=/data/local/tests/xpcshell/b
export LD_LIBRARY_PATH=/data/local/tests/xpcshell/b
export TMPDIR=/data/local/tests/xpcshell/tmp
export NS_TRACE_MALLOC_DISABLE_STACKS=1
cd $1
echo xpcw: cd $1
shift
echo xpcw: xpcshell "$@"
/data/local/tests/xpcshell/b/xpcshell "$@"

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 680414 [details] [diff] [review]
Set XPCOM_DEBUG_BREAK, etc env vars

Review of attachment 680414 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/xpcshell/remotexpcshelltests.py
@@ +262,5 @@
> +        self.env["MOZ_CRASHREPORTER_NO_REPORT"] = "1"
> +        # Capturing backtraces is very slow on some platforms, and it's
> +        # disabled by automation.py too
> +        self.env["NS_TRACE_MALLOC_DISABLE_STACKS"] = "1"
> +        self.env["XPCOM_MEM_LEAK_LOG"] = self.remoteJoin(self.profileDir, "leaks.log")

couldn't we do:
self.env = XPCShellTests.buildEnvironment(self)

We would have to modify the XPCShellTests version to find a way to start with self.enf = {} instead of os.environ.

Comment 5

[Geoff Brown [:gbrown]]

Attachment: Set XPCOM_DEBUG_BREAK, etc env vars

I couldn't find a reasonable way to make XPCShellTests.buildEnvironment generic, so this moves the cross-platform env vars into a new function and calls the new function from both XPCShellTests and the remote override.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 680762 [details] [diff] [review]
Set XPCOM_DEBUG_BREAK, etc env vars

Review of attachment 680762 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!

Comment 7

[Geoff Brown [:gbrown]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dd9da0173949

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/dd9da0173949