Closed
Bug 808856
Opened 12 years ago
Closed 10 years ago
Make not overriding WrapObject fail to build
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: ehsan.akhgari, Assigned: peterv)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
4.74 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
I keep on forgetting to override WrapObject, and I get non-obvious runtime assertions. It's much better if we make WrapObject pure virtual and fail this mistake to build.
Comment 1•12 years ago
|
||
I've tried this before, but not all of nsWrapperCache's subclasses override WrapObject; in particular some of nsDOMEventTargetHelper's subclasses. (This case in particular can be solved by implementing a no-op WrapObject on nsDOMEventTargetHelper, I guess.)
Reporter | ||
Comment 2•12 years ago
|
||
Yeah that would make sense I think.
Reporter | ||
Updated•12 years ago
|
Blocks: ParisBindings
Assignee | ||
Comment 3•10 years ago
|
||
Reporter | ||
Updated•10 years ago
|
Attachment #8500556 -
Flags: review?(ehsan.akhgari) → review+
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b2238670c5bf
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b2238670c5bf
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Updated•9 years ago
|
Flags: qe-verify-
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•